From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Antoine Levitt Newsgroups: gmane.emacs.bugs Subject: bug#11706: 24.1.50; Wrong behavior of move-end-of-line in ERC Date: Thu, 14 Jun 2012 09:48:20 +0200 Message-ID: <874nqe1ghn.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1339660175 12750 80.91.229.3 (14 Jun 2012 07:49:35 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 14 Jun 2012 07:49:35 +0000 (UTC) To: 11706@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 14 09:49:35 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sf4o9-0006XP-4C for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jun 2012 09:49:33 +0200 Original-Received: from localhost ([::1]:39383 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf4o9-00078m-49 for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jun 2012 03:49:33 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf4no-0006OW-64 for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2012 03:49:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sf4nm-00083z-EO for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2012 03:49:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60461) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf4nm-00083t-8H for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2012 03:49:10 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Sf4qX-0002Br-N0 for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2012 03:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Antoine Levitt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Jun 2012 07:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.13396602998390 (code B ref -1); Thu, 14 Jun 2012 07:52:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Jun 2012 07:51:39 +0000 Original-Received: from localhost ([127.0.0.1]:41774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sf4qB-0002BH-Eh for submit@debbugs.gnu.org; Thu, 14 Jun 2012 03:51:39 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52666) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sf4qA-0002BB-Fu for submit@debbugs.gnu.org; Thu, 14 Jun 2012 03:51:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sf4nJ-00081S-TG for submit@debbugs.gnu.org; Thu, 14 Jun 2012 03:48:46 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:47595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf4nJ-00081L-NR for submit@debbugs.gnu.org; Thu, 14 Jun 2012 03:48:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf4nD-0006OH-HC for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2012 03:48:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sf4n5-0007za-EY for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2012 03:48:34 -0400 Original-Received: from mail-wg0-f41.google.com ([74.125.82.41]:64845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf4n5-0007zB-6F for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2012 03:48:27 -0400 Original-Received: by wgbds1 with SMTP id ds1so5910644wgb.0 for ; Thu, 14 Jun 2012 00:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; bh=1GlJJi9MvG2Qne5ILq7+G751ewOjUwBE20aGNY66WlY=; b=Ro3jhnZKcdKP3Dym6Az2J00LWxc0FYca+5LIT/NPZk/g97Wp5njwPjxr2vhju3VtTW X7lRRDebEZcwAtEKoUJwhfD2stsTPWwd4msory7kM50DsTak54LRthKbeobBDcYWwnWE UIcIT5i+mYWdf0MSGGc2P6i8WJxsWjhkRjEwgKBkj9ustwyontDnl9zvGj0Voi7kUpzP irZlCzxzhYVTlwdJ4PfcrTo17teuo60ue8Qu4nLzUq8F3uPgJshCosbS9P33xKpwuJ3i RgfeHGO69k0u9DNn0NUhG8vstDSdh9gJHeR44P8DHH+okaTkoZlAdVRTTRp2efBQqjpE 4SVA== Original-Received: by 10.216.215.153 with SMTP id e25mr410067wep.189.1339660103241; Thu, 14 Jun 2012 00:48:23 -0700 (PDT) Original-Received: from lambda (portable48.ceremade.dauphine.fr. [193.48.71.48]) by mx.google.com with ESMTPS id fo7sm17298061wib.9.2012.06.14.00.48.21 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Jun 2012 00:48:22 -0700 (PDT) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60966 Archived-At: Hi, (setq erc-timestamp-only-if-changed-flag nil erc-hide-timestamps t erc-insert-timestamp-function 'erc-insert-timestamp-left) Join IRC, type a few line, then go back in the text and type C-e. Point will stop one character before EOL. It's annoying. My quick fix is diff --git a/lisp/erc/erc-stamp.el b/lisp/erc/erc-stamp.el index 5831233..b43b2b3 100644 --- a/lisp/erc/erc-stamp.el +++ b/lisp/erc/erc-stamp.el @@ -352,7 +352,7 @@ Return the empty string if FORMAT is nil." 'isearch-open-invisible 'timestamp ts) ;; N.B. Later use categories instead of this harmless, but ;; inelegant, hack. -- BPT - (when erc-timestamp-intangible + (when (and erc-timestamp-intangible (not erc-hide-timestamps)) (erc-put-text-property 0 (length ts) 'intangible t ts)) ts) "")) I think it's fine to install in trunk and certainly unlikely to cause any further bugs (there's not much point in setting something invisible as intangible), but I don't know very well how the code works, so I'd appreciate it if someone could review it and fix the whole thing consistently. Antoine