From: Antoine Levitt <antoine.levitt@gmail.com>
To: 11706@debbugs.gnu.org
Subject: bug#11706: 24.1.50; Wrong behavior of move-end-of-line in ERC
Date: Thu, 14 Jun 2012 09:48:20 +0200 [thread overview]
Message-ID: <874nqe1ghn.fsf@gmail.com> (raw)
Hi,
(setq erc-timestamp-only-if-changed-flag nil
erc-hide-timestamps t
erc-insert-timestamp-function 'erc-insert-timestamp-left)
Join IRC, type a few line, then go back in the text and type C-e. Point
will stop one character before EOL. It's annoying.
My quick fix is
diff --git a/lisp/erc/erc-stamp.el b/lisp/erc/erc-stamp.el
index 5831233..b43b2b3 100644
--- a/lisp/erc/erc-stamp.el
+++ b/lisp/erc/erc-stamp.el
@@ -352,7 +352,7 @@ Return the empty string if FORMAT is nil."
'isearch-open-invisible 'timestamp ts)
;; N.B. Later use categories instead of this harmless, but
;; inelegant, hack. -- BPT
- (when erc-timestamp-intangible
+ (when (and erc-timestamp-intangible (not erc-hide-timestamps))
(erc-put-text-property 0 (length ts) 'intangible t ts))
ts)
""))
I think it's fine to install in trunk and certainly unlikely to cause
any further bugs (there's not much point in setting something invisible
as intangible), but I don't know very well how the code works, so I'd
appreciate it if someone could review it and fix the whole thing
consistently.
Antoine
next reply other threads:[~2012-06-14 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 7:48 Antoine Levitt [this message]
2012-10-07 1:41 ` bug#11706: 24.1.50; Wrong behavior of move-end-of-line in ERC Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nqe1ghn.fsf@gmail.com \
--to=antoine.levitt@gmail.com \
--cc=11706@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.