From: Julien Danjou <julien@danjou.info>
To: Chong Yidong <cyd@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Inclusion of naquadah-theme
Date: Thu, 28 Jun 2012 12:42:51 +0200 [thread overview]
Message-ID: <874npvk990.fsf@zelenka.enovance.com> (raw)
In-Reply-To: <87sjdf28ik.fsf@gnu.org> (Chong Yidong's message of "Thu, 28 Jun 2012 15:36:03 +0800")
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
On Thu, Jun 28 2012, Chong Yidong wrote:
[…]
> The rest of the patch looks fine. Go ahead and commit once you have
> made the above changes, and thanks.
Thanks for your review! I've commited with the requested changes. If
anything bad comes up with this, don't hesitate to beat me, I'll fix. :)
> I'm not sure I understand. If you specify a face with a color like
> "#252A2B", doesn't Emacs display the closest matching color on terminals
> with limited colors?
It does try, but the result is not always good. Some colors are
correctly picked up as closest/best choice, others aren't fine. We're
doing a better job manually.
--
Julien
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2012-06-28 10:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 10:13 Inclusion of naquadah-theme Julien Danjou
2012-06-25 13:49 ` Chong Yidong
2012-06-26 10:48 ` Julien Danjou
2012-06-28 7:36 ` Chong Yidong
2012-06-28 10:42 ` Julien Danjou [this message]
2012-06-30 2:15 ` Chong Yidong
2012-07-02 21:02 ` Julien Danjou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874npvk990.fsf@zelenka.enovance.com \
--to=julien@danjou.info \
--cc=cyd@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.