From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Achim Gratz Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r110286: Sync Org 7.9.2 from the commit tagged "release_7.9.2" in Org's Git repo. Date: Wed, 03 Oct 2012 17:46:25 +0200 Organization: Linux Private Site Message-ID: <874nmbimni.fsf@Rainer.invalid> References: <87pq5267ew.fsf@bzg.ath.cx> <87626uuol5.fsf@Rainer.invalid> <5fobkm9jnu.fsf@fencepost.gnu.org> <87wqzat6n7.fsf@Rainer.invalid> <87wqz9vxmm.fsf@bzg.ath.cx> <87a9w4by89.fsf@Rainer.invalid> <87zk447pz9.fsf@bzg.ath.cx> <871uhgbwvz.fsf@Rainer.invalid> <87pq50ahk6.fsf@Rainer.invalid> <26txuchi1p.fsf@fencepost.gnu.org> <87ehlgagem.fsf@Rainer.invalid> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1349279311 8227 80.91.229.3 (3 Oct 2012 15:48:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Oct 2012 15:48:31 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 03 17:48:36 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TJRB3-0004Sh-KJ for ged-emacs-devel@m.gmane.org; Wed, 03 Oct 2012 17:48:01 +0200 Original-Received: from localhost ([::1]:33992 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJRAy-0002an-3r for ged-emacs-devel@m.gmane.org; Wed, 03 Oct 2012 11:47:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJRAt-0002Tr-5R for emacs-devel@gnu.org; Wed, 03 Oct 2012 11:47:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJRAo-0001gB-OZ for emacs-devel@gnu.org; Wed, 03 Oct 2012 11:47:51 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:41178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJRAo-0001fv-IK for emacs-devel@gnu.org; Wed, 03 Oct 2012 11:47:46 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1TJRAP-0000Pt-Du for emacs-devel@gnu.org; Wed, 03 Oct 2012 17:47:21 +0200 Original-Received: from pd9eb52a1.dip.t-dialin.net ([217.235.82.161]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 03 Oct 2012 17:47:21 +0200 Original-Received: from Stromeko by pd9eb52a1.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 03 Oct 2012 17:47:21 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 32 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: pd9eb52a1.dip.t-dialin.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) Cancel-Lock: sha1:7Ln7OxHMh0gy35+gBpzO1MtYEP8= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154010 Archived-At: Glenn Morris writes: > I wouldn't bother. A warning sometimes just means "this code use can be > problematic, maybe you want to check it", not "this code use is > definitely wrong, you should change it". Well, I couldn't help bothering… :-) The let-binding that triggers the message is actually established in autoloads.el in generate-file-autoloads, which then goes on to call autoload-generate-file-autoloads, which actually expects a buffer local variable. Apparently the let-binding "wins" in that situation and the buffer-local variable is ignored, which is probably why the warning is printed (even though the two values are the same)? I can fix this by calling autoload-generate-file-autoloads directly, setting the default value for generated-autoload-file instead of doing a let-bind. This works without printing any warnings, but fails when any of the files tries to set a buffer-local variable with a different value for generated-autoload-file: the file is produced, but does not collect any autoload definitions. It actually blows up in that case unless I provide a let-bind for autoload-modified-buffers (like in update-directory-autoloads, where I gleaned this from and which also let-binds generated-autoload-file and thus produces the same warning). Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Factory and User Sound Singles for Waldorf Q+, Q and microQ: http://Synth.Stromeko.net/Downloads.html#WaldorfSounds