bug#14815: 24.3.50; eww (Hyperlinks): Left mouse click on hyperlinks does nothing

bug#14815: 24.3.50; eww (Hyperlinks): Left mouse click on hyperlinks does nothing

[Jambunathan K]

Currently left-clicking on the hyperlinks doesn't take me to the link.
(RET works though)

Please enable left mouse clicks.



In GNU Emacs 24.3.50.10 (i686-pc-linux-gnu, GTK+ Version 2.20.1)
 of 2013-07-07 on debian-6.05
Bzr revision: 113313 jan.h.d@swipnet.se-20130707084109-gf7csgu4tkxzjn23
Windowing system distributor `The X.Org Foundation', version 11.0.10707000
Important settings:
  value of $LANG: en_IN
  locale-coding-system: iso-latin-1-unix
  default enable-multibyte-characters: t

bug#14815: 24.3.50; eww (Hyperlinks): Left mouse click on hyperlinks does nothing

[Lars Magne Ingebrigtsen]

Jambunathan K <kjambunathan@gmail.com> writes:

> Currently left-clicking on the hyperlinks doesn't take me to the link.
> (RET works though)

I'd like to, but I don't know how.  This is how the local keymap is
defined:

(defvar shr-map
  (let ((map (make-sparse-keymap)))

[...]

    (define-key map [follow-link] 'mouse-face)

What's the real way to define mouse actions these days?
    
-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#14815: 24.3.50; eww (Hyperlinks): Left mouse click on hyperlinks does nothing

[Jambunathan K]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Jambunathan K <kjambunathan@gmail.com> writes:
>
>> Currently left-clicking on the hyperlinks doesn't take me to the link.
>> (RET works though)
>
> I'd like to, but I don't know how.  This is how the local keymap is
> defined:
>
> (defvar shr-map
>   (let ((map (make-sparse-keymap)))
>
> [...]
>
>     (define-key map [follow-link] 'mouse-face)
>
> What's the real way to define mouse actions these days?

C-u C-x = on Orgmode links shows this:


    (keymap
     (follow-link . mouse-face)
     (mouse-3 . org-find-file-at-mouse)
     (mouse-2 . org-open-at-mouse))


Define keymap

    (defvar org-mouse-map (make-sparse-keymap))
    (org-defkey org-mouse-map [mouse-2] 'org-open-at-mouse)
    (org-defkey org-mouse-map [mouse-3] 'org-find-file-at-mouse)

Mouse click handlers.

    (defun org-open-at-mouse (ev)
      "Open file link or URL at mouse.
    See the docstring of `org-open-file' for details."
      (interactive "e")
      (mouse-set-point ev)
      (org-open-at-point))

    (defun org-find-file-at-mouse (ev)
      "Open file link or URL at mouse."
      (interactive "e")
      (mouse-set-point ev)
      (org-open-at-point 'in-emacs))

bug#14815: 24.3.50; eww (Hyperlinks): Left mouse click on hyperlinks does nothing

[Lars Magne Ingebrigtsen]

Jambunathan K <kjambunathan@gmail.com> writes:

> C-u C-x = on Orgmode links shows this:
>
>     (keymap
>      (follow-link . mouse-face)
>      (mouse-3 . org-find-file-at-mouse)
>      (mouse-2 . org-open-at-mouse))
>
> Define keymap
>
>     (defvar org-mouse-map (make-sparse-keymap))
>     (org-defkey org-mouse-map [mouse-2] 'org-open-at-mouse)
>     (org-defkey org-mouse-map [mouse-3] 'org-find-file-at-mouse)

Ok; I've now bound [mouse-2] in shr.

But this bug report is about the left mouse click, and that's mouse-1,
isn't it?  does the special follow-link thing do magic with remapping
mouse-2 to mouse-1?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#14815: 24.3.50; eww (Hyperlinks): Left mouse click on hyperlinks does nothing

[Jambunathan K]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Jambunathan K <kjambunathan@gmail.com> writes:
>
>> C-u C-x = on Orgmode links shows this:
>>
>>     (keymap
>>      (follow-link . mouse-face)
>>      (mouse-3 . org-find-file-at-mouse)
>>      (mouse-2 . org-open-at-mouse))
>>
>> Define keymap
>>
>>     (defvar org-mouse-map (make-sparse-keymap))
>>     (org-defkey org-mouse-map [mouse-2] 'org-open-at-mouse)
>>     (org-defkey org-mouse-map [mouse-3] 'org-find-file-at-mouse)
>
> Ok; I've now bound [mouse-2] in shr.

Middle click follows the link.

> But this bug report is about the left mouse click, and that's mouse-1,
> isn't it?  

Yes.

> does the special follow-link thing do magic with remapping
> mouse-2 to mouse-1?

Left click does NOT work in eww buffers.  (i.e., the bug is still open)

Left click still opens Org links - which look like so [[org link]] - in
Org buffers.  I am unable to quickly figure out what Org does specially
which eww misses.

Another thing I noticed: When mouse house over an link in an Org or a
Help buffer, the link's color changes.  In case of eww, this
color-changing doesn't happen.

bug#14815: 24.3.50; eww (Hyperlinks): Left mouse click on hyperlinks does nothing

[Jambunathan K]

Jambunathan K <kjambunathan@gmail.com> writes:

> Left click does NOT work in eww buffers.  (i.e., the bug is still open)
>
> Another thing I noticed: When mouse house over an link in an Org or a
> Help buffer, the link's color changes.  In case of eww, this
> color-changing doesn't happen.

If you do this, Left click works.  I have validated this experimentally
i.e., I haven't looked at docstring or info manual etc.


    ,----  DESIRED - Left click works
    | There are text properties here:
    |   face                 shr-link
    |   help-echo            "http://www.emacswiki.org/emacs-en"
    |   keymap               [Show]
    |   mouse-face           highlight <============================= Added
    |   shr-url              "http://www.emacswiki.org/emacs-en"
    `----


    ,----  CURRENT - Left click DOES NOT work
    | There are text properties here:
    |   face                 shr-link
    |   help-echo            "http://www.emacswiki.org/emacs-de"
    |   keymap               [Show]
    |   shr-url              "http://www.emacswiki.org/emacs-de"
    `----

bug#14815: 24.3.50; eww (Hyperlinks): Left mouse click on hyperlinks does nothing

[Lars Magne Ingebrigtsen]

Jambunathan K <kjambunathan@gmail.com> writes:

>     |   mouse-face           highlight <============================= Added

I've now added highlighting, too.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#14815: 24.3.50; eww (Hyperlinks): Left mouse click on hyperlinks does nothing

[Glenn Morris]

Lars Magne Ingebrigtsen wrote:

> But this bug report is about the left mouse click, and that's mouse-1,
> isn't it?  does the special follow-link thing do magic with remapping
> mouse-2 to mouse-1?

See mouse-1-click-follows-link and mouse-on-link-p.
(Basically, put the 'follow-link property on links.)

bug#14815: 24.3.50; eww (Hyperlinks): Left mouse click on hyperlinks does nothing

[Lars Magne Ingebrigtsen]

Glenn Morris <rgm@gnu.org> writes:

> (Basically, put the 'follow-link property on links.)

Ah; thanks.  Now done.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/