From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: trunk r114545: * lisp/progmodes/ruby-mode.el: Fix recently added tests. Date: Mon, 07 Oct 2013 14:29:22 +0300 Message-ID: <874n8tz5d9.fsf@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1381145588 12197 80.91.229.3 (7 Oct 2013 11:33:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Oct 2013 11:33:08 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 07 13:33:12 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VT93n-0006F7-P6 for ged-emacs-devel@m.gmane.org; Mon, 07 Oct 2013 13:33:11 +0200 Original-Received: from localhost ([::1]:58808 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VT93n-0002FM-5m for ged-emacs-devel@m.gmane.org; Mon, 07 Oct 2013 07:33:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VT90N-0005ZM-Ik for emacs-devel@gnu.org; Mon, 07 Oct 2013 07:29:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VT90I-0003SI-CG for emacs-devel@gnu.org; Mon, 07 Oct 2013 07:29:39 -0400 Original-Received: from mail-ea0-x236.google.com ([2a00:1450:4013:c01::236]:35225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VT90I-0003S8-2Q for emacs-devel@gnu.org; Mon, 07 Oct 2013 07:29:34 -0400 Original-Received: by mail-ea0-f182.google.com with SMTP id o10so3140664eaj.41 for ; Mon, 07 Oct 2013 04:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=uN1VU4mNLBL1bHgYIqQ2cwgfEfc9KvLhvE4oMYhOcgo=; b=hwlzXx73ICBX06WC4xi/cKUS1+ulN6Ow9e6YQSIWdHJtch4/za+5QPlKDRb1qZolBe G8Ezo/eNbwPaqcC5u6+x0RkmyAvMwDLjiTNpThA6p3rjIJvCWn+xFeL22+gNXMSbx4ni QLFRFlTr2XH4OtGHHhP7e4tQbwjwx8yPx6lAT07iXYx2TAR7AuDs+b8VuQZJTyQr3nBo qRGJNKeexyF6qE3UoSfGZqe7ZSGMDT/WG3z1RRyJe6820eSNjvQgD99Pl6ZfpPp7ao6x b7SMW9+5AbDxk6iOHrIAjisCAC4IP6K/Qpbo30ZJjv2WaqBtdEGNCpR9EeyirbQWZRqt Zbpw== X-Received: by 10.15.31.12 with SMTP id x12mr1030164eeu.83.1381145373146; Mon, 07 Oct 2013 04:29:33 -0700 (PDT) Original-Received: from axl (93-113-74.netrun.cytanet.com.cy. [93.109.113.74]) by mx.google.com with ESMTPSA id f49sm62285062eec.7.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 07 Oct 2013 04:29:32 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Mon, 07 Oct 2013 03:38:30 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163943 Archived-At: Stefan Monnier writes: > a = foo(j, k) - > - bar_tee > + bar_tee Hmm, that indentation looks meaningful, and it's even close to implementing one of the long-standing feature requests (http://bugs.ruby-lang.org/issues/5357), but I suspect it'll go against some established codebases. I think we'll need a toggle here, eventually. > foo. > bar > > +# FIXME: is this really valid Ruby? Isn't the newline after "foo" treated as > +# an implicit semi-colon? > foo > .bar It is, I guess it's the main exception to the newline termination rule. This style is actually preferred over keeping the dot on the first line: https://github.com/bbatsov/ruby-style-guide (search for "chained method invocation")