From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r115439: * autorevert.el (auto-revert-notify-add-watch): Do not handle symlinked files. Date: Wed, 11 Dec 2013 16:17:46 +0100 Message-ID: <874n6fifhh.fsf@gmx.de> References: <83txehxt42.fsf@gnu.org> <87mwk9uwt1.fsf@gmx.de> <83k3fcy82u.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1386775082 4398 80.91.229.3 (11 Dec 2013 15:18:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Dec 2013 15:18:02 +0000 (UTC) Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 11 16:18:07 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VqlY5-0002Jt-M4 for ged-emacs-devel@m.gmane.org; Wed, 11 Dec 2013 16:18:05 +0100 Original-Received: from localhost ([::1]:57882 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqlY5-0001Fy-7y for ged-emacs-devel@m.gmane.org; Wed, 11 Dec 2013 10:18:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqlXx-0001Fc-Mg for emacs-devel@gnu.org; Wed, 11 Dec 2013 10:18:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqlXq-0005zM-OU for emacs-devel@gnu.org; Wed, 11 Dec 2013 10:17:57 -0500 Original-Received: from mout.gmx.net ([212.227.17.20]:56460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqlXq-0005zA-FL for emacs-devel@gnu.org; Wed, 11 Dec 2013 10:17:50 -0500 Original-Received: from detlef.gmx.de ([87.146.36.183]) by mail.gmx.com (mrgmx103) with ESMTPS (Nemesis) id 0LpKY5-1VNEDJ3mC5-00fAfb for ; Wed, 11 Dec 2013 16:17:49 +0100 In-Reply-To: <83k3fcy82u.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 10 Dec 2013 18:38:49 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Provags-ID: V03:K0:kvsuB13ngKaPqlelruuQWYinm6DVV6dSavoZMz+zgyADpmpOt8Q JfOmUzZVK+uaQCRUw/cPBWEYLTtg3BBmXFndKnY/OkhcpWQGzdZ0PqhJj0fsDt9y1rq5cra olSHNLBzEvJ7uO6HNIRLcJdHghbYulTJW2s3aQllTz5FBFMnmCzymx1ymjvjTTSB7meFDRI UZsOychPr83Y6LPLcf2nQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.17.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:166299 Archived-At: Eli Zaretskii writes: >> From: Michael Albinus >> Cc: Stefan Monnier , emacs-devel@gnu.org >> Date: Tue, 10 Dec 2013 05:58:18 +0100 >> >> Eli Zaretskii writes: >> >> >> I think this patch is acceptable, but if/when we try to write a generic >> >> file-watcher Elisp API, it would be good to make this work (probably by >> >> adding a watcher on the symlink's target). >> > >> > It's up to the user to say whether she wants to watch the symlink or >> > its target, I think. >> >> In general I agree. But Stefan was commenting on my change in >> autorevert.el. Here it is obvious, that the target shall be watched. >> I believe. > > What if the target is a directory? This is not relevant for autorevert.el and file notifications - if the target is a directory, file notifications are not used (yet) in autorevert.el. I've created Bug#16112 for this. Best regards, Michael.