From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#16111: (erc-current-logfile buf) behavior differs to with-current-buffer buf Date: Wed, 11 Dec 2013 13:41:18 +0000 Message-ID: <874n6f4i9t.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1386769337 29000 80.91.229.3 (11 Dec 2013 13:42:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Dec 2013 13:42:17 +0000 (UTC) To: 16111@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 11 14:42:20 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vqk3O-0001VT-Sk for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Dec 2013 14:42:19 +0100 Original-Received: from localhost ([::1]:57039 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vqk3L-0006on-71 for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Dec 2013 08:42:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vqk3D-0006oE-Kn for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2013 08:42:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vqk38-0006e0-Mh for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2013 08:42:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57258) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vqk38-0006db-Dl for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2013 08:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vqk37-0005oE-W2 for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2013 08:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Dec 2013 13:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16111 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: submit@debbugs.gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.138676929222288 (code B ref -1); Wed, 11 Dec 2013 13:42:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 11 Dec 2013 13:41:32 +0000 Original-Received: from localhost ([127.0.0.1]:43044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vqk2e-0005nQ-EG for submit@debbugs.gnu.org; Wed, 11 Dec 2013 08:41:32 -0500 Original-Received: from fely.am-1.org ([78.47.74.50]:55506) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vqk2b-0005nE-Ow for submit@debbugs.gnu.org; Wed, 11 Dec 2013 08:41:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=Wc8WU9DIcWQY8hcytK++f/nGtavZSer0U8mlir6m4JM=; b=mwt20CRofQFb7b2QtwVZnRp3pNHwWSDzJqvJ8aH8MkfoiQ8Uc0JRMPGq69LDf7KXZkf/ajcAFNwz1KQtMMbhmpa3+B8PfFae0PtOjJ/6puU1WDskszSX+AkrcSzZUB2ab9XoIfPn3jKdOUpIGwj+7+LYMQnzpkNWKo4LHusB1hs=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1Vqk2Z-0000Fe-Io for submit@debbugs.gnu.org; Wed, 11 Dec 2013 13:41:28 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Vqk2R-0005bo-1T for submit@debbugs.gnu.org; Wed, 11 Dec 2013 20:41:19 +0700 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81753 Archived-At: Package: emacs Severity: minor My guess is that the results of (erc-current-logfile buffer) and (with-current-buffer buffer (erc-current-logfile)) were intended to be the same. However, as the function references the session buffer-local variables (erc-session-server, erc-session-port, and, indirectly, erc-server-current-nick and erc-server-process) /without/ switching to the buffer given, the results are somewhat undefined. (defun erc-current-logfile (&optional buffer) "Return the logfile to use for BUFFER. If BUFFER is nil, the value of `current-buffer' is used. This is determined by `erc-generate-log-file-name-function'. The result is converted to lowercase, as IRC is case-insensitive" (unless buffer (setq buffer (current-buffer))) (let ((target (or (buffer-name buffer) (erc-default-target))) (nick (erc-current-nick)) (server erc-session-server) (port erc-session-port)) =E2=80=A6)) (There, it may make sense to enclose the most part of the code within a with-current-buffer form.) This may show no symptoms as long as erc-save-buffer-in-logs is called in either of the buffers belonging to the same session, but I=E2=80=99m in doubt that erc-log-save-all-buffers (which may run as part of kill-emacs-hook) will behave sensible in general. --=20 FSF associate member #7257