From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenjiro NAKAYAMA Newsgroups: gmane.emacs.bugs Subject: bug#16204: eww does not respect shr-width customization Date: Sat, 21 Dec 2013 19:48:46 +0900 Message-ID: <874n624gz5.fsf@dhcp-193-97.nrt.redhat.com> References: <87ob4bwj6l.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1387623014 18259 80.91.229.3 (21 Dec 2013 10:50:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 Dec 2013 10:50:14 +0000 (UTC) Cc: Lars Magne Ingebrigtsen , Ted Zlatanov , 16204@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 21 11:50:19 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VuK8Q-0003jP-Mg for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Dec 2013 11:50:18 +0100 Original-Received: from localhost ([::1]:53756 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VuK8Q-0006wO-9w for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Dec 2013 05:50:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VuK8H-0006wE-UR for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2013 05:50:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VuK8B-0002bz-Or for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2013 05:50:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46860) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VuK8B-0002Zc-A3 for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2013 05:50:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VuK8A-0000ar-3W for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2013 05:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kenjiro NAKAYAMA Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Dec 2013 10:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16204 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16204-submit@debbugs.gnu.org id=B16204.13876229452190 (code B ref 16204); Sat, 21 Dec 2013 10:50:02 +0000 Original-Received: (at 16204) by debbugs.gnu.org; 21 Dec 2013 10:49:05 +0000 Original-Received: from localhost ([127.0.0.1]:60877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VuK7E-0000ZF-NR for submit@debbugs.gnu.org; Sat, 21 Dec 2013 05:49:05 -0500 Original-Received: from mail-pb0-f54.google.com ([209.85.160.54]:56805) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VuK7C-0000Yv-7p for 16204@debbugs.gnu.org; Sat, 21 Dec 2013 05:49:03 -0500 Original-Received: by mail-pb0-f54.google.com with SMTP id un15so3626658pbc.13 for <16204@debbugs.gnu.org>; Sat, 21 Dec 2013 02:49:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type:content-transfer-encoding; bh=OoJJRoejE4y575GmaF8g9Lx2JzKh0c73/S6lvFHpv+I=; b=Lkkib43QaS0KXfAVOqgbRGYh+wf7Mc63t0yUlqNqdw2nbjF1/ENGzZju/IxrrVVqQ4 widjTkdtv1RmhNbkZQNvUEUvVkE+amaaUPCuh0s/r8YyFJhu3YxIt37OnWq+/ElMA40w f67eNPD8VJO1xZcx7OsUmsIEYGvbktWTX5rcZZcNTyls+YmEqpP+ejzHFxAYsiKn+3x+ +iWS2bpd3/UZ3piZDxF7N9ezuunutlFbztJS6JYu1aKnB/WJ32ikacjvDv7UjrAckya4 Srbf/flp1J6jWzJRoejsQ+WGM2XQf4DRJbpvBf+VqWD72SZOnJfKG/9Nai7IbNNg+A+/ 6f7Q== X-Received: by 10.68.6.99 with SMTP id z3mr14315305pbz.114.1387622941081; Sat, 21 Dec 2013 02:49:01 -0800 (PST) Original-Received: from dhcp-193-97.nrt.redhat.com (nat-pool-nrt-t1.redhat.com. [66.187.238.10]) by mx.google.com with ESMTPSA id ha10sm20437934pbd.17.2013.12.21.02.48.58 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Dec 2013 02:48:59 -0800 (PST) User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.1 In-reply-to: <87ob4bwj6l.fsf@violet.siamics.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82320 Archived-At: > As currently implemented, eww-display-html simply resets > shr-width to nil, disrespecting any user’s customization > thereof, and providing no easy way to specify the HTML rendering > width to use in EWW buffers. Yes, I think so too. I wrote the patch to cusomize rendering-width(shr-width) easily by users. Signed-off-by: Kenjiro NAKAYAMA * net/eww.el(eww-rendering-width): New value to set rendering width. (eww-mode-map): New key map to eww-set-rendering-width. (easy-menu-define): New easy menu of eww-set-rendering-width. (eww-set-rendering-width): New function to set rendering width. (eww-display-html): Change to enable shr-width to set by users. Suggested by Ivan Shmakov diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 2263f81..43adb41 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -129,6 +129,7 @@ See also `eww-form-checkbox-selected-symbol'." (defvar eww-home-url nil) (defvar eww-start-url nil) (defvar eww-contents-url nil) +(defvar eww-rendering-width nil) (defvar eww-local-regex "localhost" "When this regex is found in the URL, it's not a keyword but an address.") @@ -255,7 +256,7 @@ word(s) will be searched for via `eww-search-prefix'." (setq eww-current-dom document) (let ((inhibit-read-only t) (after-change-functions nil) - (shr-width nil) + (shr-width eww-rendering-width) (shr-target-id (url-target (url-generic-parse-url url))) (shr-external-rendering-functions '((title . eww-tag-title) @@ -419,6 +420,7 @@ word(s) will be searched for via `eww-search-prefix'." (define-key map "B" 'eww-list-bookmarks) (define-key map [(meta n)] 'eww-next-bookmark) (define-key map [(meta p)] 'eww-previous-bookmark) + (define-key map [(meta s)] 'eww-set-rendering-width) (easy-menu-define nil map "" '("Eww" @@ -435,7 +437,8 @@ word(s) will be searched for via `eww-search-prefix'." ["Copy page URL" eww-copy-page-url t] ["Add bookmark" eww-add-bookmark t] ["List bookmarks" eww-list-bookmarks t] - ["List cookies" url-cookie-list t])) + ["List cookies" url-cookie-list t] + ["Set rendering width" eww-set-rendering-width t])) map)) (define-derived-mode eww-mode nil "eww" @@ -543,6 +546,15 @@ appears in a or tag." (url-retrieve eww-current-url 'eww-render (list eww-current-url (point)))) +(defun eww-set-rendering-width (width) + "Set the redering width." + (interactive "nSet new redering width (0: window-width) :") + (if (zerop width) + (setq eww-rendering-width nil) + (if (wholenump width) + (setq eww-rendering-width width) + (message "Set Number to rendering width")))) + ;; Form support. (defvar eww-form nil) --- Kenjiro NAKAYAMA ivan@siamics.net writes: > Package: emacs > Severity: wishlist > > As currently implemented, eww-display-html simply resets > shr-width to nil, disrespecting any user’s customization > thereof, and providing no easy way to specify the HTML rendering > width to use in EWW buffers.