From: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
To: Ivan Shmakov <ivan@siamics.net>
Cc: Lars Magne Ingebrigtsen <larsi@gnus.org>,
Ted Zlatanov <tzz@lifelogs.com>,
16204@debbugs.gnu.org
Subject: bug#16204: eww does not respect shr-width customization
Date: Sat, 21 Dec 2013 19:48:46 +0900 [thread overview]
Message-ID: <874n624gz5.fsf@dhcp-193-97.nrt.redhat.com> (raw)
In-Reply-To: <87ob4bwj6l.fsf@violet.siamics.net>
> As currently implemented, eww-display-html simply resets
> shr-width to nil, disrespecting any user’s customization
> thereof, and providing no easy way to specify the HTML rendering
> width to use in EWW buffers.
Yes, I think so too.
I wrote the patch to cusomize rendering-width(shr-width) easily by users.
Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
* net/eww.el(eww-rendering-width): New value to set rendering width.
(eww-mode-map): New key map to eww-set-rendering-width.
(easy-menu-define): New easy menu of eww-set-rendering-width.
(eww-set-rendering-width): New function to set rendering width.
(eww-display-html): Change to enable shr-width to set by users.
Suggested by Ivan Shmakov <ivan@siamics.net>
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 2263f81..43adb41 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -129,6 +129,7 @@ See also `eww-form-checkbox-selected-symbol'."
(defvar eww-home-url nil)
(defvar eww-start-url nil)
(defvar eww-contents-url nil)
+(defvar eww-rendering-width nil)
(defvar eww-local-regex "localhost"
"When this regex is found in the URL, it's not a keyword but an address.")
@@ -255,7 +256,7 @@ word(s) will be searched for via `eww-search-prefix'."
(setq eww-current-dom document)
(let ((inhibit-read-only t)
(after-change-functions nil)
- (shr-width nil)
+ (shr-width eww-rendering-width)
(shr-target-id (url-target (url-generic-parse-url url)))
(shr-external-rendering-functions
'((title . eww-tag-title)
@@ -419,6 +420,7 @@ word(s) will be searched for via `eww-search-prefix'."
(define-key map "B" 'eww-list-bookmarks)
(define-key map [(meta n)] 'eww-next-bookmark)
(define-key map [(meta p)] 'eww-previous-bookmark)
+ (define-key map [(meta s)] 'eww-set-rendering-width)
(easy-menu-define nil map ""
'("Eww"
@@ -435,7 +437,8 @@ word(s) will be searched for via `eww-search-prefix'."
["Copy page URL" eww-copy-page-url t]
["Add bookmark" eww-add-bookmark t]
["List bookmarks" eww-list-bookmarks t]
- ["List cookies" url-cookie-list t]))
+ ["List cookies" url-cookie-list t]
+ ["Set rendering width" eww-set-rendering-width t]))
map))
(define-derived-mode eww-mode nil "eww"
@@ -543,6 +546,15 @@ appears in a <link> or <a> tag."
(url-retrieve eww-current-url 'eww-render
(list eww-current-url (point))))
+(defun eww-set-rendering-width (width)
+ "Set the redering width."
+ (interactive "nSet new redering width (0: window-width) :")
+ (if (zerop width)
+ (setq eww-rendering-width nil)
+ (if (wholenump width)
+ (setq eww-rendering-width width)
+ (message "Set Number to rendering width"))))
+
;; Form support.
(defvar eww-form nil)
---
Kenjiro NAKAYAMA
ivan@siamics.net writes:
> Package: emacs
> Severity: wishlist
>
> As currently implemented, eww-display-html simply resets
> shr-width to nil, disrespecting any user’s customization
> thereof, and providing no easy way to specify the HTML rendering
> width to use in EWW buffers.
next prev parent reply other threads:[~2013-12-21 10:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 17:01 bug#16204: eww does not respect shr-width customization Ivan Shmakov
2013-12-21 10:48 ` Kenjiro NAKAYAMA [this message]
2013-12-21 11:08 ` Ivan Shmakov
2013-12-21 14:49 ` Kenjiro NAKAYAMA
2013-12-21 16:59 ` Ivan Shmakov
2013-12-21 20:24 ` bug#16204: eww does not respect shr-width customization, " Ted Zlatanov
2013-12-24 8:01 ` Lars Ingebrigtsen
2014-07-25 9:58 ` bug#16204: proposed patch for 24.4 Ivan Kanis
2014-08-05 17:31 ` Lars Magne Ingebrigtsen
2014-08-06 17:34 ` Ivan Kanis
2014-08-07 14:21 ` Ivan Kanis
2014-09-18 19:19 ` Lars Magne Ingebrigtsen
2014-09-18 23:48 ` Ivan Kanis
2014-09-21 12:27 ` Lars Magne Ingebrigtsen
2014-09-22 0:31 ` Ivan Kanis
2014-10-19 22:36 ` Lars Magne Ingebrigtsen
2014-10-20 17:40 ` Ivan Kanis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874n624gz5.fsf@dhcp-193-97.nrt.redhat.com \
--to=nakayamakenjiro@gmail.com \
--cc=16204@debbugs.gnu.org \
--cc=ivan@siamics.net \
--cc=larsi@gnus.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.