From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Re: Commit message header line Date: Fri, 02 May 2014 18:06:35 +0200 Message-ID: <874n185fn8.fsf@rosalinde.fritz.box> References: <83oazg1c1a.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1399046844 13665 80.91.229.3 (2 May 2014 16:07:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 2 May 2014 16:07:24 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 02 18:07:17 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WgFzZ-0007S4-3g for ged-emacs-devel@m.gmane.org; Fri, 02 May 2014 18:07:17 +0200 Original-Received: from localhost ([::1]:45341 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgFzY-000422-Jo for ged-emacs-devel@m.gmane.org; Fri, 02 May 2014 12:07:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgFzQ-00041v-BS for emacs-devel@gnu.org; Fri, 02 May 2014 12:07:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgFzK-0001j7-Am for emacs-devel@gnu.org; Fri, 02 May 2014 12:07:08 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:58274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgFzK-0001iu-25; Fri, 02 May 2014 12:07:02 -0400 Original-Received: from rosalinde.fritz.box ([89.245.97.102]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0LpObx-1XKZ1S3SDN-00f9kE; Fri, 02 May 2014 18:06:59 +0200 In-Reply-To: <83oazg1c1a.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 May 2014 17:38:09 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.90 (gnu/linux) X-Provags-ID: V03:K0:rCd/yAjB+WUc7Xf9rTBTmveqOYrJx8vkuq/bKX9b3scc0iRzvQG lGAFj8GHgQQ9HHV3mxtqxwoceVBmEOR8w61fVC4hR+O1OFhrxH8mca8Ry52N2/OmbxyQZ3v P9T5gZAoaQsED7kmt4F7u6Dw118cbR6R02A9YdsqsnhMVpEAc569C4KFyLTojNc4Akv+SIE QSsz/mPVx6KWqXYbmXIiw== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.15.19 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:171673 Archived-At: On Fri, 02 May 2014 17:38:09 +0300 Eli Zaretskii wrote: > Header lines such as these: > > Add a warning and a menu. > > Update, improve exposition, add cross references, fix typos. > > could be more useful if they included a reference to the feature you > are fixing, in this case Todo Mode. Otherwise, the header lines are > too generic. Oh dear, sorry about that. Is it possible to fix that without reverting and recommitting? I did this via VC, and thought the commit message would include the string "calendar/todo-mode.el", since it is in the ChangeLog entry copied into the commit log buffer, but I see it is not in the log listing. But I notice that other log entries do have such a string; were they explicitly added to the Subject: line in the commit log buffer, or is that because the Subject: line was left blank so just the first line of the ChangeLog entry was used? If so, is that acceptable practice, or should the Subject: line always be filled in? Steve Berman