From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daimrod Newsgroups: gmane.emacs.bugs Subject: bug#17772: [PATCH] Dangling channels' buffer Date: Sat, 14 Jun 2014 10:20:07 +0900 Message-ID: <874mzob83c.fsf@tanger.home> References: <87k38lay6k.fsf@tanger.home> <878up0b8u3.fsf@tanger.home> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1402708886 24854 80.91.229.3 (14 Jun 2014 01:21:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Jun 2014 01:21:26 +0000 (UTC) Cc: Ryan Yeske , Leo Liu , 17772@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 14 03:21:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wvcej-0001pO-Rc for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Jun 2014 03:21:18 +0200 Original-Received: from localhost ([::1]:33850 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wvcej-0002ly-7d for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jun 2014 21:21:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wvcea-0002l2-E4 for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 21:21:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvceU-0002qR-GW for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 21:21:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvceU-0002qN-Cn for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 21:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WvceT-0007Nt-T7 for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 21:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daimrod Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Jun 2014 01:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17772 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 17772-submit@debbugs.gnu.org id=B17772.140270882128310 (code B ref 17772); Sat, 14 Jun 2014 01:21:01 +0000 Original-Received: (at 17772) by debbugs.gnu.org; 14 Jun 2014 01:20:21 +0000 Original-Received: from localhost ([127.0.0.1]:47076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wvcdo-0007MV-Tt for submit@debbugs.gnu.org; Fri, 13 Jun 2014 21:20:21 -0400 Original-Received: from mail-pa0-f52.google.com ([209.85.220.52]:64459) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wvcdm-0007MD-5x for 17772@debbugs.gnu.org; Fri, 13 Jun 2014 21:20:19 -0400 Original-Received: by mail-pa0-f52.google.com with SMTP id eu11so2675010pac.11 for <17772@debbugs.gnu.org>; Fri, 13 Jun 2014 18:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=UQ2G3yx7o+5+SjcUdnPJ6nY+UpOsAFBNxSOa1guSzI8=; b=XWCIRqglAQC/3feacRYzAeiglrpSKGxGAvkraEYgfT/prpBQ6bPdDCunFkl0XR8Gfu +umjSxSptOVdxENoJu6fByGp7/EbvEwQK33YU6KS6Jf6rUrF4ZSjAZNPujXFLh8Nd0tP rU8DkKwmbNgSisnxemCC6TJPQ5Bu6QP10fVTF+Ok3pAFg2rAZfIu0lyriYMs0623IWl2 tBSj3oNcJ9zgfS5NBNZ4o0Wq4Zx7aEthgZS99UEldPkVaLoAzFp3//0yASpQzT76NDbq S9GMS/FeX8tXk0j18o3TCsQjreH4bY9Gv84vF4X29pRlEcqU6W8RfcJ4SaVC0cViI5Hl rGdA== X-Received: by 10.68.94.225 with SMTP id df1mr7448915pbb.86.1402708812080; Fri, 13 Jun 2014 18:20:12 -0700 (PDT) Original-Received: from localhost (i118-21-141-133.s30.a048.ap.plala.or.jp. [118.21.141.133]) by mx.google.com with ESMTPSA id iz2sm5825844pbb.95.2014.06.13.18.20.09 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jun 2014 18:20:10 -0700 (PDT) In-Reply-To: <878up0b8u3.fsf@tanger.home> (daimrod@gmail.com's message of "Sat, 14 Jun 2014 10:04:04 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90364 Archived-At: --=-=-= Content-Type: text/plain Daimrod writes: > Stefan Monnier writes: > >>> server process when it existed, or nil. However, since a78d87e7ed it >>> raises an error. >> >> Please avoid using Git references until we actually switch to Git. >> Use dates, for example, instead. > > Ok, I'll keep this in mind. Here is a new patch with your proposal: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-lisp-net-rcirc.el-rcirc-buffer-process-Return-the-pr.patch >From af9d16684d8449cfb006f70c4c2c1fe228e737fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Jadi?= Date: Sat, 14 Jun 2014 10:10:59 +0900 Subject: [PATCH] * lisp/net/rcirc.el (rcirc-buffer-process): Return the process associated with the channel, or nil if it doesn't exit. Since 2014-04-09, the current behavior was to raise an error if the process didn't exist. This restore the previous behavior. --- lisp/net/rcirc.el | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 41cc002..73a6395 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -803,10 +803,10 @@ Function is called with PROCESS, COMMAND, SENDER, ARGS and LINE.") "Return the process associated with channel BUFFER. With no argument or nil as argument, use the current buffer." (let ((buffer (or buffer (if (buffer-live-p rcirc-server-buffer) - rcirc-server-buffer - (error "Server buffer deleted"))))) - (or (with-current-buffer buffer rcirc-process) - rcirc-process))) + rcirc-server-buffer)))) + (if buffer + (with-current-buffer buffer rcirc-process) + rcirc-process))) (defun rcirc-server-name (process) "Return PROCESS server name, given by the 001 response." -- 1.8.0.2722.gc0242e5 --=-=-= Content-Type: text/plain -- Daimrod/Greg --=-=-=--