From: handa@gnu.org (K. Handa)
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 17973@debbugs.gnu.org
Subject: bug#17973: Thin space not thin at all
Date: Mon, 14 Jul 2014 00:12:58 +0900 [thread overview]
Message-ID: <874myle1hh.fsf@gnu.org> (raw)
In-Reply-To: <jwvzjghmeli.fsf-monnier+emacsbugs@gnu.org> (message from Stefan Monnier on Thu, 10 Jul 2014 12:37:27 -0400)
In article <jwvzjghmeli.fsf-monnier+emacsbugs@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Ah, right, that explains it. Hmm... I guess ideally, Emacs should
> consider a height that's "too far" from the requested one as a failure
> and then try again ignoring some of the specs.
font_find_for_lface has a code to do that, but I found that
it is called with full font properties in SPEC. This
function does not try a font of different properties
(foundry, family, registry, adstyle).
> The patch below expresses the first part, but it looks like the second
> part doesn't exit: Emacs just doesn't find any font to use for the "thin
> space" of C-x SPC and indicates it to me with one of those big squares
> that say "0020", which is a lot more intrusive than the problem I'm
> trying to fix.
In addition to your patch, could you please try the following patch?
=== modified file 'src/xfaces.c'
--- src/xfaces.c 2014-07-07 23:33:05 +0000
+++ src/xfaces.c 2014-07-13 15:09:21 +0000
@@ -5547,7 +5547,7 @@
}
if (! FONT_OBJECT_P (attrs[LFACE_FONT_INDEX]))
attrs[LFACE_FONT_INDEX]
- = font_load_for_lface (f, attrs, attrs[LFACE_FONT_INDEX]);
+ = font_load_for_lface (f, attrs, Ffont_spec (0, NULL));
if (FONT_OBJECT_P (attrs[LFACE_FONT_INDEX]))
{
face->font = XFONT_OBJECT (attrs[LFACE_FONT_INDEX]);
> PS: The patch below also happens to give me assertion failures
> fontset.c:897: Emacs fatal error: assertion failed: fontset_id_valid_p (face->fontset)
> I haven't investigated any further, tho (and the line number might be off
> because of local changes anyway).
I didn't face with that error, but I'll keep on checking the code.
---
Kenichi Handa
handa@gnu.org
next prev parent reply other threads:[~2014-07-13 15:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 18:07 bug#17973: Thin space not thin at all Stefan Monnier
2014-07-09 15:32 ` K. Handa
2014-07-09 19:21 ` Stefan Monnier
2014-07-10 14:28 ` K. Handa
2014-07-10 16:37 ` Stefan Monnier
2014-07-13 15:12 ` K. Handa [this message]
2014-07-19 6:13 ` Stefan Monnier
2014-07-19 15:57 ` K. Handa
2014-07-19 17:30 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874myle1hh.fsf@gnu.org \
--to=handa@gnu.org \
--cc=17973@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.