From: Nick Dokos <ndokos@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: Org 8 Bug in interactive formula editing mode?
Date: Tue, 22 Jul 2014 16:48:01 -0400 [thread overview]
Message-ID: <874my9azni.fsf@alphaville.bos.redhat.com> (raw)
In-Reply-To: 87a981b0g3.fsf@alphaville.bos.redhat.com
Nick Dokos <ndokos@gmail.com> writes:
> Robert Klein <roklein@roklein.de> writes:
>
>> I made some quick tests with different org versions; the first one I see
>> this issue is git commit 30220ffcdcef45c0237f80a2347d4da19877f64a
>> (release_8.2.6-77-g30220f).
>>
>> I don't see the patch causing this, yet; have to look further.
>>
>
> Absolutely right, that looks like the culprit:
>
> ,----
> | commit 30220ffcdcef45c0237f80a2347d4da19877f64a
> | Author: Bastien Guerry <bzg@altern.org>
> | Date: Thu Jun 12 12:04:24 2014 +0200
> |
> | Prefer `set-window-start' over `recenter' in some places.
> |
> | * org-agenda.el (org-agenda-show-1):
> | * org-table.el (org-table-show-reference): <<<<<<<<<<<<<< this change
> | * org.el (org-fix-ellipsis-at-bol)
> | (org-first-headline-recenter): Use `set-window-start' instead
> | of `recenter'.
> |
> | * org-agenda.el (org-recenter-heading): Delete.
> `----
The diff was
,----
| diff --git a/lisp/org-table.el b/lisp/org-table.el
| index 1d6bee0..6d649ab 100644
| --- a/lisp/org-table.el
| +++ b/lisp/org-table.el
| @@ -3863,9 +3863,10 @@ With prefix ARG, apply the new formulas to the table."
| (push org-table-current-begin-pos org-show-positions)
| (let ((min (apply 'min org-show-positions))
| (max (apply 'max org-show-positions)))
| - (goto-char min) (recenter 0)
| + (set-window-start (selected-window) (point-min))
| (goto-char max)
| - (or (pos-visible-in-window-p max) (recenter -1))))
| + (or (pos-visible-in-window-p max)
| + (set-window-start (selected-window) (point-max)))))
| (select-window win))))
|
| (defun org-table-force-dataline ()
`----
I suspect that instead of (point-min), it should be just min
and instead of point-max, it should be just max (or possibly
the beginning of the next line if it exists).
Nick
next prev parent reply other threads:[~2014-07-22 20:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 7:09 Org 8 Bug in interactive formula editing mode? Thorsten Grothe
2014-07-21 13:50 ` Thorsten Grothe
2014-07-21 13:57 ` Nick Dokos
2014-07-21 16:14 ` Thorsten Grothe
2014-07-21 17:19 ` Nick Dokos
2014-07-21 18:36 ` Thorsten Grothe
2014-07-21 19:17 ` Thorsten Grothe
2014-07-21 19:36 ` Thorsten Grothe
2014-07-21 20:25 ` Nick Dokos
2014-07-22 6:27 ` Robert Klein
2014-07-22 8:14 ` Thorsten Grothe
2014-07-22 8:58 ` Nick Dokos
2014-07-22 17:09 ` Thorsten Grothe
2014-07-22 17:39 ` Nick Dokos
2014-07-22 19:01 ` Nick Dokos
2014-07-22 19:29 ` Robert Klein
2014-07-22 20:30 ` Nick Dokos
2014-07-22 20:48 ` Nick Dokos [this message]
2014-07-22 20:56 ` Thorsten Grothe
2014-07-22 21:37 ` Nick Dokos
2014-07-23 6:56 ` Thorsten Grothe
2014-07-24 4:04 ` Nick Dokos
2014-07-27 16:13 ` Bastien
2014-07-22 21:47 ` Nick Dokos
2014-07-22 8:32 ` Nick Dokos
2014-07-22 20:37 ` Luke Crook
2014-07-22 20:31 ` Luke Crook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874my9azni.fsf@alphaville.bos.redhat.com \
--to=ndokos@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.