From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#18632: 24.3.94; image-dired fail when `image-dired-dir' doesn't exist Date: Sun, 05 Oct 2014 16:12:30 +0200 Organization: Emacs Helm Message-ID: <874mvi7ghd.fsf@gmail.com> References: <871tqmskw1.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1412518473 2887 80.91.229.3 (5 Oct 2014 14:14:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 5 Oct 2014 14:14:33 +0000 (UTC) To: 18632@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 05 16:14:26 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XamZs-0000Fe-8U for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Oct 2014 16:14:24 +0200 Original-Received: from localhost ([::1]:47613 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XamZr-0002Eu-PO for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Oct 2014 10:14:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XamZg-0002Bf-19 for bug-gnu-emacs@gnu.org; Sun, 05 Oct 2014 10:14:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XamZW-0005aW-5Z for bug-gnu-emacs@gnu.org; Sun, 05 Oct 2014 10:14:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43238) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XamZW-0005aS-2a for bug-gnu-emacs@gnu.org; Sun, 05 Oct 2014 10:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XamZV-0005Mp-NA for bug-gnu-emacs@gnu.org; Sun, 05 Oct 2014 10:14:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <871tqmskw1.fsf@gmail.com> Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Oct 2014 14:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.141251839620569 (code B ref -1); Sun, 05 Oct 2014 14:14:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Oct 2014 14:13:16 +0000 Original-Received: from localhost ([127.0.0.1]:34802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XamYl-0005Lg-PJ for submit@debbugs.gnu.org; Sun, 05 Oct 2014 10:13:16 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33890) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XamYi-0005LW-WF for submit@debbugs.gnu.org; Sun, 05 Oct 2014 10:13:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XamYY-0004wl-Vy for submit@debbugs.gnu.org; Sun, 05 Oct 2014 10:13:12 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:50749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XamYY-0004we-Sm for submit@debbugs.gnu.org; Sun, 05 Oct 2014 10:13:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XamYR-0001kD-Bo for bug-gnu-emacs@gnu.org; Sun, 05 Oct 2014 10:13:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XamYJ-0004r7-Ry for bug-gnu-emacs@gnu.org; Sun, 05 Oct 2014 10:12:55 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:52490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XamYJ-0004qT-Li for bug-gnu-emacs@gnu.org; Sun, 05 Oct 2014 10:12:47 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XamYI-0007z1-77 for bug-gnu-emacs@gnu.org; Sun, 05 Oct 2014 16:12:46 +0200 Original-Received: from lbe83-2-78-243-104-167.fbx.proxad.net ([78.243.104.167]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 05 Oct 2014 16:12:46 +0200 Original-Received: from thierry.volpiatto by lbe83-2-78-243-104-167.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 05 Oct 2014 16:12:46 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 27 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: lbe83-2-78-243-104-167.fbx.proxad.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.94 (gnu/linux) Cancel-Lock: sha1:ewsSIVJUmbpjGOMhJClk8yMTJE4= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:94164 Archived-At: Thierry Volpiatto writes: > If `image-dired-dir' doesn't exists, image-dired fail with > something like "could not resize image" with no indications on what is happening. > IOW image-dired should create its directory when this one doesn't > exists, or at least send a helpful message to notify user he have first > to create manually this directory. diff --git a/lisp/image-dired.el b/lisp/image-dired.el index 114deab..01f88c2 100644 --- a/lisp/image-dired.el +++ b/lisp/image-dired.el @@ -1800,7 +1800,8 @@ should feel snappy enough. If optional argument ORIGINAL-SIZE is non-nil, display image in its original size." - (let ((new-file (expand-file-name image-dired-temp-image-file)) + (let ((new-file (expand-file-name image-dired-temp-image-file + (image-dired-dir))) width height command ret (image-type 'jpeg)) (setq file (expand-file-name file)) -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997