From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: 18632@debbugs.gnu.org
Subject: bug#18632: 24.3.94; image-dired fail when `image-dired-dir' doesn't exist
Date: Sun, 05 Oct 2014 16:12:30 +0200 [thread overview]
Message-ID: <874mvi7ghd.fsf@gmail.com> (raw)
In-Reply-To: <871tqmskw1.fsf@gmail.com>
Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:
> If `image-dired-dir' doesn't exists, image-dired fail with
> something like "could not resize image" with no indications on what is happening.
> IOW image-dired should create its directory when this one doesn't
> exists, or at least send a helpful message to notify user he have first
> to create manually this directory.
diff --git a/lisp/image-dired.el b/lisp/image-dired.el
index 114deab..01f88c2 100644
--- a/lisp/image-dired.el
+++ b/lisp/image-dired.el
@@ -1800,7 +1800,8 @@ should feel snappy enough.
If optional argument ORIGINAL-SIZE is non-nil, display image in its
original size."
- (let ((new-file (expand-file-name image-dired-temp-image-file))
+ (let ((new-file (expand-file-name image-dired-temp-image-file
+ (image-dired-dir)))
width height command ret
(image-type 'jpeg))
(setq file (expand-file-name file))
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
next prev parent reply other threads:[~2014-10-05 14:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-05 13:31 bug#18632: 24.3.94; image-dired fail when `image-dired-dir' doesn't exist Thierry Volpiatto
2014-10-05 14:12 ` Thierry Volpiatto [this message]
2019-08-29 22:32 ` Stefan Kangas
2019-08-30 5:34 ` Thierry Volpiatto
2019-08-30 10:39 ` Stefan Kangas
2019-08-30 6:31 ` Eli Zaretskii
2019-08-30 10:41 ` Stefan Kangas
2019-09-26 16:37 ` Lars Ingebrigtsen
2022-09-16 0:39 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mvi7ghd.fsf@gmail.com \
--to=thierry.volpiatto@gmail.com \
--cc=18632@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.