From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sylvain Chouleur Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] icalendar.el: Support timezones without DST Date: Sun, 16 Nov 2014 18:19:02 +0100 Message-ID: <874mtzqd15.fsf@nuada.dyved.org> References: <87r3xcc7vh.fsf@nuada.dyved.org> <87r3xb3rtq.fsf@web.de> <87ppcnaywp.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1416158371 3534 80.91.229.3 (16 Nov 2014 17:19:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 16 Nov 2014 17:19:31 +0000 (UTC) Cc: Emacs developers To: Ulf Jasper Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 16 18:19:25 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xq3Tu-0006ru-BD for ged-emacs-devel@m.gmane.org; Sun, 16 Nov 2014 18:19:22 +0100 Original-Received: from localhost ([::1]:44529 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xq3Tt-0006F5-8r for ged-emacs-devel@m.gmane.org; Sun, 16 Nov 2014 12:19:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xq3Tm-0006Cs-DO for emacs-devel@gnu.org; Sun, 16 Nov 2014 12:19:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xq3Th-0001ST-RN for emacs-devel@gnu.org; Sun, 16 Nov 2014 12:19:14 -0500 Original-Received: from 85-171-169-178.rev.numericable.fr ([85.171.169.178]:46888 helo=nuada.dyved.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xq3Th-0001S6-Jo for emacs-devel@gnu.org; Sun, 16 Nov 2014 12:19:09 -0500 Original-Received: from nuada.dyved.org (localhost [IPv6:::1]) by nuada.dyved.org (Postfix) with ESMTPS id 8FE9D484172; Sun, 16 Nov 2014 18:19:02 +0100 (CET) In-Reply-To: <87ppcnaywp.fsf@web.de> (Ulf Jasper's message of "Sun, 16 Nov 2014 17:33:10 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 85.171.169.178 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:177325 Archived-At: --=-=-= Content-Type: text/plain Ulf Jasper writes: > Ulf Jasper writes: > >> Sylvain Chouleur writes: >> >>> This patch is here to support vcalendar events which timezone doesn't >>> have daylight saving time. >> >> I'll have a look at the patch. Thanks. > > Your patch broke the automatic test! But that was due to an error in > the test. ;) After a minor tweak it is working now. Thanks for the patch! > > Could you please provide an anonymized sample so that I can add another "real > world test case"? Hi, An example of timezone reproducing the issue is +03:30 Asia/Tehran I created a sample with http://apps.marudot.com/ical/ --=-=-= Content-Type: text/calendar Content-Disposition: inline; filename=Test.ics BEGIN:VCALENDAR VERSION:2.0 PRODID:-//www.marudot.com//iCal Event Maker X-WR-CALNAME:Test CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Tehran TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Tehran X-LIC-LOCATION:Asia/Tehran BEGIN:STANDARD TZOFFSETFROM:+0330 TZOFFSETTO:+0330 TZNAME:IRST DTSTART:19700101T000000 END:STANDARD END:VTIMEZONE BEGIN:VEVENT DTSTAMP:20141116T171439Z UID:20141116T171439Z-678877132@marudot.com DTSTART;TZID="Asia/Tehran":20141116T070000 DTEND;TZID="Asia/Tehran":20141116T080000 SUMMARY:NoDST DESCRIPTION:Test event from timezone without DST LOCATION:Everywhere END:VEVENT END:VCALENDAR --=-=-= Content-Type: text/plain Regards, -- Sylvain --=-=-=--