From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Marcin Borkowski Newsgroups: gmane.emacs.help Subject: Re: Counting SLOC in Emacs Date: Fri, 28 Nov 2014 15:31:09 +0100 Message-ID: <874mtjjt31.fsf@wmi.amu.edu.pl> References: <877fyfk1qn.fsf@wmi.amu.edu.pl> <8761dzjvcl.fsf@wmi.amu.edu.pl> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1417185135 1924 80.91.229.3 (28 Nov 2014 14:32:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 28 Nov 2014 14:32:15 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Fri Nov 28 15:32:13 2014 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XuMah-00053a-S4 for geh-help-gnu-emacs@m.gmane.org; Fri, 28 Nov 2014 15:32:12 +0100 Original-Received: from localhost ([::1]:44683 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuMah-0007JH-D9 for geh-help-gnu-emacs@m.gmane.org; Fri, 28 Nov 2014 09:32:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuMZr-0006Yc-HV for help-gnu-emacs@gnu.org; Fri, 28 Nov 2014 09:31:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XuMZq-0003RE-7P for help-gnu-emacs@gnu.org; Fri, 28 Nov 2014 09:31:19 -0500 Original-Received: from msg.wmi.amu.edu.pl ([2001:808:114:2::50]:34348) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuMZp-0003Qw-Vf for help-gnu-emacs@gnu.org; Fri, 28 Nov 2014 09:31:18 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by msg.wmi.amu.edu.pl (Postfix) with ESMTP id 3258442068 for ; Fri, 28 Nov 2014 15:31:16 +0100 (CET) Original-Received: from msg.wmi.amu.edu.pl ([127.0.0.1]) by localhost (msg.wmi.amu.edu.pl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yJySd5vHUf8t for ; Fri, 28 Nov 2014 15:31:16 +0100 (CET) Original-Received: from localhost (unknown [IPv6:2001:808:114:6:9d5b:51e1:6d47:a8a9]) by msg.wmi.amu.edu.pl (Postfix) with ESMTPSA id 0AC8B42062 for ; Fri, 28 Nov 2014 15:31:16 +0100 (CET) In-reply-to: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:808:114:2::50 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:101270 Archived-At: On 2014-11-28, at 15:04, Stefan Monnier wrote: >> (save-excursion >> (save-restriction >> (narrow-to-region beg end) >> (goto-char (point-min)) >> (let ((count 0)) >> (while (not (eobp)) > > I'd use > > (save-excursion > (goto-char beg > (let ((count 0)) > (while (< (point) end) > since narrowing can have all kinds of weird effects. OK. >> (message "SLOC in %s: %s." >> (if (use-region-p) "region" "buffer") >> count))))) > > And don't re-call use-region-p here, in the off-chance that it returns > something else than in the first call. E.g. you can use (if (and (= > beg (point-min)) (= end (point-max))) "buffer" "region") instead. I don't think it's probable (or even possible), but definitely my solution was not very elegant. I wonder whether (let)ting (use-region-p) to a temporary variable wouldn't be better. Anyway, thanks for your review! I will write a blog post about this function (googling for "emacs count sloc" doesn't yield anything useful, let's change it! ;-) ). > Stefan -- Marcin Borkowski http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski Faculty of Mathematics and Computer Science Adam Mickiewicz University