From: Marcin Borkowski <mbork@wmi.amu.edu.pl>
To: help-gnu-emacs@gnu.org
Subject: Re: Counting SLOC in Emacs
Date: Fri, 28 Nov 2014 15:31:09 +0100 [thread overview]
Message-ID: <874mtjjt31.fsf@wmi.amu.edu.pl> (raw)
In-Reply-To: <jwvr3wne85m.fsf-monnier+gmane.emacs.help@gnu.org>
On 2014-11-28, at 15:04, Stefan Monnier wrote:
>> (save-excursion
>> (save-restriction
>> (narrow-to-region beg end)
>> (goto-char (point-min))
>> (let ((count 0))
>> (while (not (eobp))
>
> I'd use
>
> (save-excursion
> (goto-char beg
> (let ((count 0))
> (while (< (point) end)
> since narrowing can have all kinds of weird effects.
OK.
>> (message "SLOC in %s: %s."
>> (if (use-region-p) "region" "buffer")
>> count)))))
>
> And don't re-call use-region-p here, in the off-chance that it returns
> something else than in the first call. E.g. you can use (if (and (=
> beg (point-min)) (= end (point-max))) "buffer" "region") instead.
I don't think it's probable (or even possible), but definitely my
solution was not very elegant. I wonder whether (let)ting
(use-region-p) to a temporary variable wouldn't be better.
Anyway, thanks for your review! I will write a blog post about this
function (googling for "emacs count sloc" doesn't yield anything
useful, let's change it! ;-) ).
> Stefan
--
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University
next prev parent reply other threads:[~2014-11-28 14:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 11:23 Counting SLOC in Emacs Marcin Borkowski
2014-11-28 13:41 ` Marcin Borkowski
2014-11-28 14:04 ` Stefan Monnier
2014-11-28 14:31 ` Marcin Borkowski [this message]
2014-11-28 14:49 ` Stefan Monnier
2014-11-28 16:00 ` Marcin Borkowski
2014-11-29 9:46 ` Thien-Thi Nguyen
2014-11-29 11:49 ` Marcin Borkowski
2014-11-29 14:36 ` Grant Rettke
2014-12-02 20:43 ` Robert Thorpe
2014-12-02 22:10 ` Marcin Borkowski
[not found] ` <mailman.14877.1417186246.1147.help-gnu-emacs@gnu.org>
2014-12-02 14:35 ` Ted Zlatanov
2014-12-03 1:14 ` Leo Liu
2014-12-30 14:05 ` Marcin Borkowski
2014-12-31 11:50 ` Leo Liu
2014-12-31 13:25 ` Marcin Borkowski
2014-11-28 16:46 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mtjjt31.fsf@wmi.amu.edu.pl \
--to=mbork@wmi.amu.edu.pl \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.