From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#19645: 25.0.50; Recent EIEIO changes broke helm: Lisp error: (cl-no-next-method helm--setup-source... Date: Fri, 23 Jan 2015 08:08:05 +0100 Organization: Emacs Helm Message-ID: <874mrinfe2.fsf@gmail.com> References: <87sif4txdv.fsf@gnu.org> <87lhkvz4dt.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1421996954 30340 80.91.229.3 (23 Jan 2015 07:09:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 Jan 2015 07:09:14 +0000 (UTC) To: 19645@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 23 08:09:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YEYMh-0003mr-NA for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Jan 2015 08:09:12 +0100 Original-Received: from localhost ([::1]:57439 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEYMg-0004r4-SO for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Jan 2015 02:09:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEYMd-0004qw-4f for bug-gnu-emacs@gnu.org; Fri, 23 Jan 2015 02:09:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEYMZ-0005o1-2X for bug-gnu-emacs@gnu.org; Fri, 23 Jan 2015 02:09:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEYMY-0005nx-VR for bug-gnu-emacs@gnu.org; Fri, 23 Jan 2015 02:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YEYMY-0001U5-M9 for bug-gnu-emacs@gnu.org; Fri, 23 Jan 2015 02:09:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87sif4txdv.fsf@gnu.org> Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Jan 2015 07:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19645 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14219969125634 (code B ref -1); Fri, 23 Jan 2015 07:09:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Jan 2015 07:08:32 +0000 Original-Received: from localhost ([127.0.0.1]:53456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEYM3-0001So-Go for submit@debbugs.gnu.org; Fri, 23 Jan 2015 02:08:31 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:33645) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEYM1-0001SV-7u for submit@debbugs.gnu.org; Fri, 23 Jan 2015 02:08:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEYLv-0005YE-1x for submit@debbugs.gnu.org; Fri, 23 Jan 2015 02:08:24 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:57221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEYLu-0005YA-VS for submit@debbugs.gnu.org; Fri, 23 Jan 2015 02:08:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEYLt-0004TP-Se for bug-gnu-emacs@gnu.org; Fri, 23 Jan 2015 02:08:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEYLp-0005X1-RJ for bug-gnu-emacs@gnu.org; Fri, 23 Jan 2015 02:08:21 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:52085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEYLp-0005Wt-KO for bug-gnu-emacs@gnu.org; Fri, 23 Jan 2015 02:08:17 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1YEYLm-0002ug-S4 for bug-gnu-emacs@gnu.org; Fri, 23 Jan 2015 08:08:14 +0100 Original-Received: from 37.160.178.68 ([37.160.178.68]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 23 Jan 2015 08:08:14 +0100 Original-Received: from thierry.volpiatto by 37.160.178.68 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 23 Jan 2015 08:08:14 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 54 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 37.160.178.68 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Cancel-Lock: sha1:MhRK3hcrcAJWP9QuPnoxT8QWluE= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98618 Archived-At: Stefan Monnier writes: > I'm still wondering why you'd use a :before method when there's no > primary method. To ensure this method run BEFORE the other same methods that run for other classes: --8<---------------cut here---------------start------------->8--- (defclass helm-test-class (helm-source-sync helm-type-file) ((candidates :initform (lambda () ("foo" "bar" "baz"))))) =>helm-test-class (helm-make-source "test" 'helm-test-class) 1) With helm-type-file `helm--setup-source' method is :before => ((name . "test") (candidates lambda nil ("foo" "bar" "baz")) (action ("Find file" . helm-find-many-files) ("Find file as root" . helm-find-file-as-root) ("Find file other window" . find-file-other-window) ("Find file other frame" . find-file-other-frame) [...] (persistent-help . "Show this file") [...] (match helm-mp-exact-match helm-mp-3-match) (header-line . "C-j: Show this file (keeping session)") (dont-plug helm-compile-source--match-plugin helm-compile-source--persistent-help) (matchplugin)) 2) With helm-type-file `helm--setup-source' method is only :primary => ((name . "test") (candidates lambda nil ("foo" "bar" "baz")) (action . identity) (match helm-mp-exact-match helm-mp-3-match) (dont-plug helm-compile-source--match-plugin helm-compile-source--persistent-help) (matchplugin)) --8<---------------cut here---------------end--------------->8--- As you can see when the helm--setup-source method of helm-type-file is not :before, the default slots (common to both class) of helm-source-sync take precedence. The helm-test-class have to inherit from two classes, and the helm-type-file class should overhide the default slot of the helm-source-sync class. Maybe there is another way to achieve this ? -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997