From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: 19645@debbugs.gnu.org
Subject: bug#19645: 25.0.50; Recent EIEIO changes broke helm: Lisp error: (cl-no-next-method helm--setup-source...
Date: Fri, 23 Jan 2015 08:08:05 +0100 [thread overview]
Message-ID: <874mrinfe2.fsf@gmail.com> (raw)
In-Reply-To: <87sif4txdv.fsf@gnu.org>
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> I'm still wondering why you'd use a :before method when there's no
> primary method.
To ensure this method run BEFORE the other same methods that run for
other classes:
--8<---------------cut here---------------start------------->8---
(defclass helm-test-class (helm-source-sync helm-type-file)
((candidates :initform (lambda () ("foo" "bar" "baz")))))
=>helm-test-class
(helm-make-source "test" 'helm-test-class)
1) With helm-type-file `helm--setup-source' method is :before
=>
((name . "test")
(candidates lambda nil ("foo" "bar" "baz"))
(action ("Find file" . helm-find-many-files)
("Find file as root" . helm-find-file-as-root)
("Find file other window" . find-file-other-window)
("Find file other frame" . find-file-other-frame)
[...]
(persistent-help . "Show this file")
[...]
(match helm-mp-exact-match helm-mp-3-match)
(header-line . "C-j: Show this file (keeping session)")
(dont-plug helm-compile-source--match-plugin helm-compile-source--persistent-help)
(matchplugin))
2) With helm-type-file `helm--setup-source' method is only :primary
=>
((name . "test")
(candidates lambda nil ("foo" "bar" "baz"))
(action . identity)
(match helm-mp-exact-match helm-mp-3-match)
(dont-plug helm-compile-source--match-plugin helm-compile-source--persistent-help)
(matchplugin))
--8<---------------cut here---------------end--------------->8---
As you can see when the helm--setup-source method of helm-type-file is
not :before, the default slots (common to both class) of helm-source-sync
take precedence.
The helm-test-class have to inherit from two classes, and
the helm-type-file class should overhide the default slot of the
helm-source-sync class.
Maybe there is another way to achieve this ?
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
next prev parent reply other threads:[~2015-01-23 7:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 7:18 bug#19645: 25.0.50; Recent EIEIO changes broke helm: Lisp error: (cl-no-next-method helm--setup-source Tassilo Horn
2015-01-21 16:03 ` Stefan Monnier
2015-01-21 16:38 ` Thierry Volpiatto
2015-01-21 17:36 ` Thierry Volpiatto
2015-01-21 19:51 ` Stefan Monnier
2015-01-21 19:49 ` Stefan Monnier
2015-01-21 20:58 ` Thierry Volpiatto
2015-01-21 21:53 ` Stefan Monnier
2015-01-22 4:17 ` Stefan Monnier
2015-01-22 7:00 ` Tassilo Horn
2015-01-22 17:08 ` Stefan Monnier
2015-01-23 7:08 ` Thierry Volpiatto [this message]
2015-01-23 20:56 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mrinfe2.fsf@gmail.com \
--to=thierry.volpiatto@gmail.com \
--cc=19645@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.