all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: David Kastrup <dak@gnu.org>
To: emacs-devel@gnu.org
Subject: What's up with apply-partially?
Date: Fri, 23 Jan 2015 23:14:06 +0100	[thread overview]
Message-ID: <874mrh5emp.fsf@fencepost.gnu.org> (raw)


The original definition of apply-partially in subr.el by Eli in 2008 has
been

(defun apply-partially (fun &rest args)
  "Return a function that is a partial application of FUN to ARGS.
ARGS is a list of the first N arguments to pass to FUN.
The result is a new function which does the same as FUN, except that
the first N arguments are fixed at the values with which this function
was called."
  (lexical-let ((fun fun) (args1 args))
    (lambda (&rest args2) (apply fun (append args1 args2)))))

The current definition by Stefan, however, is
(defun apply-partially (fun &rest args)
  "Return a function that is a partial application of FUN to ARGS.
ARGS is a list of the first N arguments to pass to FUN.
The result is a new function which does the same as FUN, except that
the first N arguments are fixed at the values with which this function
was called."
  `(closure (t) (&rest args)
            (apply ',fun ,@(mapcar (lambda (arg) `',arg) args) args)))

Now subr.el has lexical-bind set.  It seems quite pointless to return
some unevaluated quoted list here (apply-partially is not a macro but a
function!).

So why not just

(defun apply-partially (fun &rest args)
  (lambda (&rest args2) (apply fun (append args args2))))

Where is the point in the complicated redefinition that returns a
basically uncompiled function?  Why not just take Eli's definition and
simplify it in line with lexical-binding now being set?

I don't understand the point of the change.  Lexical bindings should
have made this function more straightforward.  Instead it has become
more complex and unevaluated.  And it's not like describe-function even
knows `closure', as opposed to `lambda'.  So it's become inscrutable as
well.

-- 
David Kastrup



             reply	other threads:[~2015-01-23 22:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 22:14 David Kastrup [this message]
2015-01-24  3:05 ` What's up with apply-partially? Leo Liu
2015-01-24  5:01   ` Stefan Monnier
2015-01-24  8:54     ` David Kastrup
2015-01-25 14:32       ` Stefan Monnier
2015-01-25 19:45         ` [PATCH] Let apply-partially make use of lexical binding in subr.el David Kastrup
2015-01-27 16:12           ` David Kastrup
2015-01-29 15:01             ` Stefan Monnier
2015-01-29 15:17               ` David Kastrup
2015-02-05 17:55                 ` David Kastrup
2015-01-24  3:53 ` What's up with apply-partially? Artur Malabarba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mrh5emp.fsf@fencepost.gnu.org \
    --to=dak@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.