From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#19950: 25.0.50; Gnus nnimap -- don't split messages back into original group Date: Fri, 27 Feb 2015 13:48:54 +0800 Message-ID: <874mq7vr95.fsf@ericabrahamsen.net> References: <87ioepnx98.fsf@ericabrahamsen.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1425016263 6815 80.91.229.3 (27 Feb 2015 05:51:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 Feb 2015 05:51:03 +0000 (UTC) To: 19950@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 27 06:50:48 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YRDp1-00056o-8I for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Feb 2015 06:50:47 +0100 Original-Received: from localhost ([::1]:34114 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRDp0-0002In-Op for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Feb 2015 00:50:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRDoM-00019p-Pn for bug-gnu-emacs@gnu.org; Fri, 27 Feb 2015 00:50:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRDoJ-0003Fy-Il for bug-gnu-emacs@gnu.org; Fri, 27 Feb 2015 00:50:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRDoJ-0003FV-Fl for bug-gnu-emacs@gnu.org; Fri, 27 Feb 2015 00:50:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YRDoI-0005Jn-LD; Fri, 27 Feb 2015 00:50:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87ioepnx98.fsf@ericabrahamsen.net> Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Fri, 27 Feb 2015 05:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19950 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.142501615720386 (code B ref -1); Fri, 27 Feb 2015 05:50:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Feb 2015 05:49:17 +0000 Original-Received: from localhost ([127.0.0.1]:59195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRDnY-0005Ik-Vw for submit@debbugs.gnu.org; Fri, 27 Feb 2015 00:49:17 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56820) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRDnW-0005IW-U7 for submit@debbugs.gnu.org; Fri, 27 Feb 2015 00:49:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRDnQ-00032j-Q5 for submit@debbugs.gnu.org; Fri, 27 Feb 2015 00:49:09 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:38488) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRDnQ-00032c-NV for submit@debbugs.gnu.org; Fri, 27 Feb 2015 00:49:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRDnP-0007IM-I9 for bug-gnu-emacs@gnu.org; Fri, 27 Feb 2015 00:49:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRDnM-00031N-AH for bug-gnu-emacs@gnu.org; Fri, 27 Feb 2015 00:49:07 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:42689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRDnM-000315-3n for bug-gnu-emacs@gnu.org; Fri, 27 Feb 2015 00:49:04 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1YRDnJ-0003xg-Eo for bug-gnu-emacs@gnu.org; Fri, 27 Feb 2015 06:49:01 +0100 Original-Received: from 111.199.145.15 ([111.199.145.15]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 27 Feb 2015 06:49:01 +0100 Original-Received: from eric by 111.199.145.15 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 27 Feb 2015 06:49:01 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 80 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 111.199.145.15 User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) Cancel-Lock: sha1:akg2Xaa4nEMq5ChC0bt9Ct9Rtk0= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99856 Archived-At: --=-=-= Content-Type: text/plain Stefan Monnier writes: >> If this is acceptable, does it need a CHANGELOG mention? I've gotten >> pretty confused about what's LOG-worthy, and what isn't. > > The ChangeLog duplicates the commit messages, and since every commit should > have a commit message, then every commit should add that same message > to the relevant ChangeLog. > > At least for now, until we finally change our procedure to auto-generate > the ChangeLog files (should be "real soon now", tho there hasn't been > much activity in this area of late). Thanks to you both! Here's a new patch with ChangeLog added. I'll just leave this here until Lars sees it... --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Don-t-split-imap-messages-back-into-original-group.patch >From ffbbdec9909bc08d853d239b798bd33726e6fa82 Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Wed, 18 Feb 2015 17:51:37 +0800 Subject: [PATCH] Don't split imap messages back into original group * lisp/nnimap.el (nnimap-split-incoming-mail): If a message is already in the group it should be split to, don't re-copy it into the group. --- lisp/ChangeLog | 4 ++++ lisp/nnimap.el | 15 +++++++++------ 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 2047481..011e3cd 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,7 @@ +2015-02-27 Eric Abrahamsen + * lisp/nnimap.el (nnimap-split-incoming-mail): If a message is already + in the group it should be split to, don't re-copy it into the group. + 2015-02-26 Katsumi Yamaoka * gnus-art.el (gnus-mime-inline-part, gnus-mm-display-part): diff --git a/lisp/nnimap.el b/lisp/nnimap.el index 369d9d3..c476be6 100644 --- a/lisp/nnimap.el +++ b/lisp/nnimap.el @@ -2086,12 +2086,15 @@ Return the server's response to the SELECT or EXAMINE command." (ranges (cdr spec))) (if (eq group 'junk) (setq junk-articles ranges) - (push (list (nnimap-send-command - "UID COPY %s %S" - (nnimap-article-ranges ranges) - (utf7-encode group t)) - ranges) - sequences)))) + ;; Don't copy if the message is already in its + ;; target group. + (unless (string= group nnimap-inbox) + (push (list (nnimap-send-command + "UID COPY %s %S" + (nnimap-article-ranges ranges) + (utf7-encode group t)) + ranges) + sequences))))) ;; Wait for the last COPY response... (when sequences (nnimap-wait-for-response (caar sequences)) -- 2.3.1 --=-=-=--