From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.devel Subject: Re: Should Emacs define push-tag-mark? Date: Wed, 29 Apr 2015 08:08:46 +0200 Message-ID: <874mnziapg.fsf@gmail.com> References: <87618gkrxx.fsf@gmail.com> <55400825.2050301@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1430297874 10271 80.91.229.3 (29 Apr 2015 08:57:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 29 Apr 2015 08:57:54 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 29 10:57:49 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YnNoQ-0002q0-Qc for ged-emacs-devel@m.gmane.org; Wed, 29 Apr 2015 10:57:46 +0200 Original-Received: from localhost ([::1]:37814 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnNoQ-00027e-3k for ged-emacs-devel@m.gmane.org; Wed, 29 Apr 2015 04:57:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnNit-0007w6-Nw for emacs-devel@gnu.org; Wed, 29 Apr 2015 04:52:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnNio-0004O1-NA for emacs-devel@gnu.org; Wed, 29 Apr 2015 04:52:03 -0400 Original-Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:35074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnNio-0004NY-Ay for emacs-devel@gnu.org; Wed, 29 Apr 2015 04:51:58 -0400 Original-Received: by widdi4 with SMTP id di4so170901447wid.0 for ; Wed, 29 Apr 2015 01:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:references:message-id:user-agent :mime-version:content-type; bh=bZT71Bdl+9UHtciKuTXF3TJoNq84TPnPQyREfZNrz6E=; b=nrg1yVU31+uB+E1NWR7JJyqBYjILtZWj2CY5EAWP31H2/17d/z+5OWpO6b6hAzyzGT DDsGI1xXinHIGAzqSwr+SjIcd0XjSPgrH5Xfi1W9N4HsayKNcKEctsfG8q54Ws0yQ/k+ AgzZ8GTGqBe2fuRnSZRW8PsXoi/xsZPzD+kLOfYwb2p5LT/e6KmabuoVkwvkMgIQfUSi iiXbviDH2qsy3Ws7cvzGGR5Wo5aTdOvUYSMvwYkoDSAH75qGs+ItMd2kTmkd/nzdTEsD Qi3pTsU85XEru03QfP/AD5XuSQf7tw7GuavtPLw+l0pA4rRM0L/O3yt4bt1gErZxbwm4 +mmw== X-Received: by 10.180.37.207 with SMTP id a15mr6546935wik.2.1430297516989; Wed, 29 Apr 2015 01:51:56 -0700 (PDT) Original-Received: from firefly (dyn069045.nbw.tue.nl. [131.155.69.45]) by mx.google.com with ESMTPSA id gu7sm20167981wib.21.2015.04.29.01.51.56 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 29 Apr 2015 01:51:56 -0700 (PDT) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:186001 Archived-At: Dmitry Gutov writes: > On 04/28/2015 09:50 PM, Oleh Krehel wrote: >> >> I was just looking at why `pop-tag-mark' wasn't working after >> `semantic-ia-fast-jump'. Turns out it's because GNU/Emacs doesn't >> define `push-tag-mark' on which `semantic-ia-fast-jump' relies. >> >> Should I define this function? It would also fix #5666. > > In master, you can use `xref-push-marker-stack'. And it works with `pop-tag-mark' too, neat. Should #5666 be closed then? How are bugs closed, by the way? I'll send a patch to CEDET to use `xref-push-marker-stack' as well. Oleh