From: Nicolas Petton <nicolas@petton.fr>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Nicolas Petton <nicolas@petton.fr>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 387e1e1: New version of `seq-let' based on a pcase pattern
Date: Mon, 11 May 2015 15:42:39 +0200 [thread overview]
Message-ID: <874mnjdycw.fsf@petton.fr> (raw)
In-Reply-To: <jwvzj5bzsky.fsf-monnier+emacsdiffs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2130 bytes --]
Stefan Monnier writes:
>> + (pcase-defmacro seq (bindings)
>> + `(and ,@(seq--make-pcase-bindings bindings)))
>
> If you put a docstring in there, it will appear in "C-h f pcase RET", so
> you can use it to document the particular format you support.
Great, I'll do that.
> Also I see the following problems:
> - You only accept the form (seq <binding>) rather than (seq <binding1>
> <binding2> ...), so typical cases will have to use (seq (a b)) instead
> (seq a b).
Yes. My idea of it was that you bind a sequence like the following:
(seq [a b [c d]])
Or did you have something else in mind?
> - The above pcase pattern doesn't check that it's indeed a `seq'.
> You should add a (pred seq-p). It will automatically be optimized
> away in `pcase-let', but is indispensable for the `pcase' situation to
> do the right thing.
Ok, I'll do that.
>
>> +(defun seq--make-pcase-bindings (args &optional bindings nested-indexes)
> [...]
>> + (seq-doseq (name args)
>> + (unless rest-marker
>> + (pcase name
>> + ((pred seq-p)
>
> IIUC, this means that (pcase-let (((seq a (seq b c)) <obj>)) <body>)
> will bind the `seq' variable to the first element of the nested sequence
> (and `a' to the second and `b' to the third), whereas I think it should
> bind `b' to the first element of the nested sequence (which is what
> would happen if you simply removed this branch of this `pcase').
> I think removing this case will also remove the need for
> seq--nested-elt.
But then how can I have `seq-let' work the way it did until now? For
instance:
(seq-let [a [b [c]]] my-vector
...)
>> + (push `(app (seq--reverse-args #'seq--nested-elt
>> + (reverse (cons ,index ',nested-indexes)))
>> + ,name)
>
> This reverse plus seq--reverse-args business seems
> hideously inefficient. Why do you need that?
because of the way the `app' pattern works. Or maybe I'm missing
something?
Nico
--
Nicolas Petton
http://nicolas-petton.fr
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2015-05-11 13:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150510182502.23307.63648@vcs.savannah.gnu.org>
[not found] ` <E1YrVuR-00064X-CK@vcs.savannah.gnu.org>
2015-05-11 4:15 ` [Emacs-diffs] master 387e1e1: New version of `seq-let' based on a pcase pattern Stefan Monnier
2015-05-11 13:42 ` Nicolas Petton [this message]
2015-05-11 15:06 ` Stefan Monnier
2015-05-11 21:13 ` Nicolas Petton
2015-05-11 21:35 ` Nicolas Petton
2015-05-12 1:03 ` Stefan Monnier
2015-05-12 6:51 ` Nicolas Petton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mnjdycw.fsf@petton.fr \
--to=nicolas@petton.fr \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.