From: phillip.lord@newcastle.ac.uk (Phillip Lord)
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: RFM: How to make a buffer-local var in C layer
Date: Tue, 15 Sep 2015 16:27:29 +0100 [thread overview]
Message-ID: <874mivln32.fsf@russet.org.uk> (raw)
In-Reply-To: <jwva8sn7ol6.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Tue, 15 Sep 2015 10:20:38 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Both are C variables of type Lisp_Object.
> The "V" one contains the value of the variable
> `fontification-functions', while the Q one contains the symbol
> `fontification-functions'.
Ah, yes, okay.
>> Fsetq(Qfontification_functions,Qt)
>
> BTW, one notable difference (other than performance) between
>
> Fset (Qfontification_functions, Qt);
> and
> Vfontification_functions = Qt;
>
> is that the former will obey make-variable-buffer-local while the
> latter won't. So if you want the var to be buffer-local, either use the
> former, or make sure to call Fmake_local_variable explicitly at
> some point.
Okay. Performance is irrelevant here, to be honest, so I've gone for
Fset.
I've pushed those changes up to my branch now and they appear to be
working. I think that I have all the C support that I need, and I'd
welcome any comments that you have (don't worry about all the commits
and change messages -- I'm planning on squashing before I'd think about
moving to master).
I'll add the emacs-lisp support next, which should be relatively
simple(.el).
Phil
prev parent reply other threads:[~2015-09-15 15:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150821093606.11577.60349@vcs.savannah.gnu.org>
[not found] ` <E1ZSik4-000326-4S@vcs.savannah.gnu.org>
2015-08-30 3:30 ` [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change e5ff575 2/2: Add a timer to ensure undo-boundaries in buffers Stefan Monnier
2015-09-01 12:24 ` Phillip Lord
2015-09-01 16:16 ` Stefan Monnier
2015-09-01 17:19 ` Phillip Lord
2015-09-06 23:03 ` Stefan Monnier
2015-09-14 14:41 ` RFM: How to make a buffer-local var in C layer Phillip Lord
2015-09-15 1:48 ` Stefan Monnier
2015-09-15 12:08 ` Phillip Lord
2015-09-15 14:18 ` Stefan Monnier
2015-09-15 14:20 ` Stefan Monnier
2015-09-15 15:27 ` Phillip Lord [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mivln32.fsf@russet.org.uk \
--to=phillip.lord@newcastle.ac.uk \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.