From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#21602: 25.0.50; coding system seg fault Date: Sat, 03 Oct 2015 14:07:19 +0200 Message-ID: <874mi8b1fs.fsf@igel.home> References: <83vbap7nv6.fsf@gnu.org> <83fv1s448p.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1443874104 9406 80.91.229.3 (3 Oct 2015 12:08:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 3 Oct 2015 12:08:24 +0000 (UTC) Cc: rms@gnu.org To: 21602@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 03 14:08:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZiLbn-0003f8-3Y for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Oct 2015 14:08:11 +0200 Original-Received: from localhost ([::1]:38186 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZiLbm-0003zZ-H1 for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Oct 2015 08:08:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZiLbh-0003yA-RO for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2015 08:08:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZiLbe-0008A1-K1 for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2015 08:08:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35684) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZiLbe-00089x-GM for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2015 08:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZiLbe-0000Zq-7I for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2015 08:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Oct 2015 12:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21602 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 21602-submit@debbugs.gnu.org id=B21602.14438740442168 (code B ref 21602); Sat, 03 Oct 2015 12:08:02 +0000 Original-Received: (at 21602) by debbugs.gnu.org; 3 Oct 2015 12:07:24 +0000 Original-Received: from localhost ([127.0.0.1]:52887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZiLb2-0000Yu-FF for submit@debbugs.gnu.org; Sat, 03 Oct 2015 08:07:24 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.10]:34787) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZiLaz-0000Yl-T0 for 21602@debbugs.gnu.org; Sat, 03 Oct 2015 08:07:22 -0400 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3nSn4T2q5Dz3hjTX; Sat, 3 Oct 2015 14:07:21 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3nSn4T0k4Tzvh1r; Sat, 3 Oct 2015 14:07:21 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id oa5tA-hA4w5L; Sat, 3 Oct 2015 14:07:19 +0200 (CEST) X-Auth-Info: P7uFUtJMWTF06SJPv/A96t6l56Qo9zvEU4Hz4D/SLepyP/n0dgaOFJvT/xYTPtaV Original-Received: from igel.home (ppp-93-104-63-53.dynamic.mnet-online.de [93.104.63.53]) by mail.mnet-online.de (Postfix) with ESMTPA; Sat, 3 Oct 2015 14:07:19 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 1000) id 529CC2C3E4A; Sat, 3 Oct 2015 14:07:19 +0200 (CEST) X-Yow: On the other hand, life can be an endless parade of TRANSSEXUAL QUILTING BEES aboard a cruise ship to DISNEYWORLD if only we let it!! In-Reply-To: <83fv1s448p.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 03 Oct 2015 13:48:38 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107255 Archived-At: Eli Zaretskii writes: > diff --git a/src/fileio.c b/src/fileio.c > index e4b255a..65aaf57 100644 > --- a/src/fileio.c > +++ b/src/fileio.c > @@ -3470,7 +3470,10 @@ by calling `format-decode', which see. */) > mtime = time_error_value (save_errno); > st.st_size = -1; > if (!NILP (Vcoding_system_for_read)) > - Fset (Qbuffer_file_coding_system, Vcoding_system_for_read); > + { > + CHECK_CODING_SYSTEM (Vcoding_system_for_read); > + Fset (Qbuffer_file_coding_system, Vcoding_system_for_read); > + } This is not needed, it is already checked later. If buffer-file-coding-system cannot tolerate a non-coding-system then checks must be added somewhere else. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."