From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: Emacs rewrite in a maintainable language Date: Wed, 14 Oct 2015 12:56:38 +0200 Message-ID: <874mhtra55.fsf@gnu.org> References: <561A19AB.5060001@cumego.com> <87io6dl0h0.fsf@wanadoo.es> <87lhb82qxc.fsf@gmail.com> <878u78b3hg.fsf@fencepost.gnu.org> <87h9lwyv33.fsf@gmail.com> <561C368F.6010306@cs.ucla.edu> <87oag3xb2i.fsf@gmail.com> <561D241E.1010902@cs.ucla.edu> <87vbaaagr5.fsf@gmail.com> <86io6amqhd.fsf@gmail.com> <06472760353f91fb2b6a1e427e954a70@mail.iq.pl> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1444820332 13023 80.91.229.3 (14 Oct 2015 10:58:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 14 Oct 2015 10:58:52 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?utf-8?Q?Przemys=C5=82aw?= Wojnowski Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 14 12:58:40 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZmJlX-0000Rz-4D for ged-emacs-devel@m.gmane.org; Wed, 14 Oct 2015 12:58:39 +0200 Original-Received: from localhost ([::1]:41568 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmJlW-0000cM-93 for ged-emacs-devel@m.gmane.org; Wed, 14 Oct 2015 06:58:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmJjg-0000IN-Cs for emacs-devel@gnu.org; Wed, 14 Oct 2015 06:56:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmJjc-000767-TO for emacs-devel@gnu.org; Wed, 14 Oct 2015 06:56:44 -0400 Original-Received: from nsmtp.uni-koblenz.de ([141.26.64.14]:59964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmJjc-00074l-NG for emacs-devel@gnu.org; Wed, 14 Oct 2015 06:56:40 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by nsmtp.uni-koblenz.de (Postfix) with ESMTP id A0143239F28; Wed, 14 Oct 2015 12:56:39 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at uni-koblenz.de Original-Received: from nsmtp.uni-koblenz.de ([127.0.0.1]) by localhost (nsmtp.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 83jCDRaxfBCk; Wed, 14 Oct 2015 12:56:39 +0200 (CEST) Original-Received: from deliver.uni-koblenz.de (deliver.uni-koblenz.de [141.26.64.15]) by nsmtp.uni-koblenz.de (Postfix) with ESMTPS; Wed, 14 Oct 2015 12:56:39 +0200 (CEST) Original-Received: from thinkpad-t440p (dhcp66.uni-koblenz.de [141.26.71.66]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id 657751A82E1; Wed, 14 Oct 2015 12:56:39 +0200 (CEST) Mail-Followup-To: =?utf-8?Q?Przemys=C5=82aw?= Wojnowski , emacs-devel@gnu.org In-Reply-To: <06472760353f91fb2b6a1e427e954a70@mail.iq.pl> (=?utf-8?Q?=22P?= =?utf-8?Q?rzemys=C5=82aw?= Wojnowski"'s message of "Wed, 14 Oct 2015 12:22:15 +0200") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 141.26.64.14 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191539 Archived-At: Przemys=C5=82aw Wojnowski writes: >>> I don't. I have no problem spending time to replace "char const *" >>> into "const char *". Browsing through a code base that I want to get >>> familiar with and fixing a small annoyance doesn't sound bad to me. >> >> Pointless churn. Find something that fixes an bug, or adds a useful >> new feature, and work on that. You will find it more rewarding, and >> other users and developers will find your contribution more helpful. > > Refactorings that increase maintainability (like this one) are very > useful to other developers. > > Such changes, even small, accumulate towards something that can be > called a "maintainable system". In (wannabe) healthy systems it is > everyday practice. OTOH, they reduce the helpfulness version control offers to new and old developers. I.e., it's good when "git blame" shows you the last changes which actually changed the code, and switching "char const *" to "const char *" or vice versa are no real changes. In the same vein, it's of course good to have one consistent indentation style, one consistent style of setting braces, one consistent style of naming variables, etc. But I'd suggest to clean up the non-conforming parts only when you do significant changes in that area anyhow. Bye, Tassilo