From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: taylanbayirli@gmail.com (Taylan Ulrich =?utf-8?Q?Bay=C4=B1rl=C4=B1?= =?utf-8?Q?=2FKammer?=) Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add shell-quasiquote. Date: Tue, 20 Oct 2015 18:31:00 +0200 Message-ID: <874mhljyd7.fsf@T420.taylan> References: <87si59wj42.fsf@T420.taylan> <878u6znii9.fsf@T420.taylan> <836123gfh2.fsf@gnu.org> <87r3krm0t3.fsf@T420.taylan> <5624F66F.1030600@yandex.ru> <87io63lzkg.fsf@T420.taylan> <562508B7.3020202@yandex.ru> <876122n5v3.fsf@T420.taylan> <22053.50324.60123.654292@turnbull.sk.tsukuba.ac.jp> <87d1waknl1.fsf@T420.taylan> <87oafugeia.fsf@fencepost.gnu.org> <87wpuij5vm.fsf@T420.taylan> <87d1w9hql5.fsf@fencepost.gnu.org> <87oaftkjhg.fsf@T420.taylan> <83fv15ft07.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1445358674 14866 80.91.229.3 (20 Oct 2015 16:31:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 Oct 2015 16:31:14 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 20 18:31:13 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZoZod-0003Tk-H5 for ged-emacs-devel@m.gmane.org; Tue, 20 Oct 2015 18:31:11 +0200 Original-Received: from localhost ([::1]:46991 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoZod-0004ZL-44 for ged-emacs-devel@m.gmane.org; Tue, 20 Oct 2015 12:31:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoZoW-0004XE-7K for emacs-devel@gnu.org; Tue, 20 Oct 2015 12:31:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoZoV-0003Tl-18 for emacs-devel@gnu.org; Tue, 20 Oct 2015 12:31:04 -0400 Original-Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:36917) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoZoU-0003TW-R7; Tue, 20 Oct 2015 12:31:02 -0400 Original-Received: by wicfv8 with SMTP id fv8so37282792wic.0; Tue, 20 Oct 2015 09:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type:content-transfer-encoding; bh=3Moa7CMO2ynSqNW4MF4OHV6cGwf4ck9EYx02/b23LOg=; b=Ow0d7sRUIEn7D77RwEwH13oEbDIoKvKVsCEyW103zwNG2+wSPBqPVOo1wJjnAADMtA fwTUmHb71cP/BhY/v1z0NVPwxnFpXnuvVqvvlqArAi9Zp+UNWDWZZE/JBHuQvtl7fJiR X0Ql+2N7mYdUrttZd0fKp9AE17sNeDqDoJLlykhzbA84+epshxpDZYl4/iLsPW8k9kd5 0d04TuXINCsTodlZRayAwFfAK0dDVbIThy4GR932UUs+nWZHnsdf7LVqsgS51zmve/S2 EscFsHnLLObueWs8QNex3Dqz30R8kuATkvyUVhmAPvTsg3exErRjAegbe2nSmad+VnUN przQ== X-Received: by 10.180.8.164 with SMTP id s4mr5876995wia.5.1445358662275; Tue, 20 Oct 2015 09:31:02 -0700 (PDT) Original-Received: from T420.taylan ([2a02:908:c32:4740:221:ccff:fe66:68f0]) by smtp.gmail.com with ESMTPSA id gh9sm4809942wjb.27.2015.10.20.09.31.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2015 09:31:00 -0700 (PDT) In-Reply-To: <83fv15ft07.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 20 Oct 2015 18:40:24 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192200 Archived-At: Eli Zaretskii writes: >> From: taylanbayirli@gmail.com (Taylan Ulrich Bay=C4=B1rl=C4=B1/Kammer) >> Date: Tue, 20 Oct 2015 10:54:51 +0200 >> Cc: "Stephen J. Turnbull" , >> emacs-devel >>=20 >> I didn't break anything, explained why I could not support non-POSIX >> without Eli's help, asked for proper help, drafted a patch where he >> could have just filled the blanks in documentation to declare the >> required safety guarantees for non-POSIX systems, but nope... > > This is not about non-Posix shells (although that aspect did start > this thread). This is about using project-wide APIs for certain > standard jobs. That should have been a no-brainer, because it makes > no sense to have several functions doing the same job in subtly > different ways. > > So you were politely requested to call that function for quoting shell > arguments in your package. Doing that is the only thing that stands > in the way of accepting your package on ELPA. AFAIK, there were no > other comments. > > If you think shell-quote-argument should be changed, feel free to > submit a patch proposal to that effect, and state there your reasons > for the changes. If they are accepted, all Lisp programs in Emacs > that need to quote command arguments will work that way, and everybody > will win by having a better Emacs. I've already provided an extensive explanation of the problem with shell-quote-argument, what the solution to that problem is, and provided a patch to apply that solution. The patch was turned down. (By you.) > I cannot understand why you insist on tying your contribution with two > orthogonal issues: what and how should be quoted, and what should be > in the doc string. By doing this, you prevent acceptance of your > package, which IMO is a pity. I don't know what you mean with "what and how should be quoted." The doc string can serve as a clear declaration of strict safety guarantees that will make the function appropriate for my use case. Until that's done, the function is not appropriate for my use case because it does not declare the guarantees necessary for my use case. In practical terms, as explained before, this means that someone editing the function in the future may insert bugs into it which, from what I've gathered from other posts in the thread, it indeed also had in the past. It has also not been verified whether it's void of such bugs for systems other than POSIX, which is why I left declaring that to you; my patches were only adding the declaration of safety for POSIX, which I've made very sure of and gladly take responsibility for. All of these things I've already said before, multiple times, with different wording, every time as clearly as I could. Taylan