* Re: [Emacs-diffs] master 9145e79: * lisp/files.el: Don't allow customization of dir-locals sorting
[not found] ` <E1Zw815-0002Gt-E0@vcs.savannah.gnu.org>
@ 2015-11-10 14:16 ` John Wiegley
2015-11-10 15:49 ` Artur Malabarba
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: John Wiegley @ 2015-11-10 14:16 UTC (permalink / raw)
To: emacs-devel; +Cc: Eli Zaretskii, Artur Malabarba
>>>>> Artur Malabarba <bruce.connor.am@gmail.com> writes:
> In retrospect, this is not a good idea for the same reason that
> `dir-locals-file' is a defconst, because it is important that this
> behaviour be "uniform across different environments and users".
> Sure, the user can still change the sorting with a hack, but we
> shouldn't encourage them to change it.
I'm inclined to agree with this; but did you mention it to Eli also, who had
suggested using version<? I think string< is the right behavior, but since we
had discussed it, I'd like to hear from him too.
John
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master 9145e79: * lisp/files.el: Don't allow customization of dir-locals sorting
2015-11-10 14:16 ` [Emacs-diffs] master 9145e79: * lisp/files.el: Don't allow customization of dir-locals sorting John Wiegley
@ 2015-11-10 15:49 ` Artur Malabarba
2015-11-10 16:32 ` Eli Zaretskii
2015-11-11 0:37 ` Juri Linkov
2 siblings, 0 replies; 5+ messages in thread
From: Artur Malabarba @ 2015-11-10 15:49 UTC (permalink / raw)
To: emacs-devel; +Cc: Eli Zaretskii
John Wiegley <jwiegley@gmail.com> writes:
> I'm inclined to agree with this; but did you mention it to Eli also, who had
> suggested using version<? I think string< is the right behavior, but since we
> had discussed it, I'd like to hear from him too.
>
Sure. I only really realised this after reading the docstring for `dir-locals-file'.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master 9145e79: * lisp/files.el: Don't allow customization of dir-locals sorting
2015-11-10 14:16 ` [Emacs-diffs] master 9145e79: * lisp/files.el: Don't allow customization of dir-locals sorting John Wiegley
2015-11-10 15:49 ` Artur Malabarba
@ 2015-11-10 16:32 ` Eli Zaretskii
2015-11-10 16:34 ` John Wiegley
2015-11-11 0:37 ` Juri Linkov
2 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2015-11-10 16:32 UTC (permalink / raw)
To: John Wiegley; +Cc: bruce.connor.am, emacs-devel
> From: John Wiegley <jwiegley@gmail.com>
> Cc: Artur Malabarba <bruce.connor.am@gmail.com>, Eli Zaretskii <eliz@gnu.org>
> Date: Tue, 10 Nov 2015 06:16:00 -0800
>
> >>>>> Artur Malabarba <bruce.connor.am@gmail.com> writes:
>
> > In retrospect, this is not a good idea for the same reason that
> > `dir-locals-file' is a defconst, because it is important that this
> > behaviour be "uniform across different environments and users".
> > Sure, the user can still change the sorting with a hack, but we
> > shouldn't encourage them to change it.
>
> I'm inclined to agree with this; but did you mention it to Eli also, who had
> suggested using version<? I think string< is the right behavior, but since we
> had discussed it, I'd like to hear from him too.
I didn't suggest using version<, at least not directly. I said that
if people who use Unix startup scripts are used to this order, I have
no objection to using string< in our similar features.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master 9145e79: * lisp/files.el: Don't allow customization of dir-locals sorting
2015-11-10 16:32 ` Eli Zaretskii
@ 2015-11-10 16:34 ` John Wiegley
0 siblings, 0 replies; 5+ messages in thread
From: John Wiegley @ 2015-11-10 16:34 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: bruce.connor.am, emacs-devel
>>>>> Eli Zaretskii <eliz@gnu.org> writes:
>> I'm inclined to agree with this; but did you mention it to Eli also, who
>> had suggested using version<? I think string< is the right behavior, but
>> since we had discussed it, I'd like to hear from him too.
> I didn't suggest using version<, at least not directly. I said that if
> people who use Unix startup scripts are used to this order, I have no
> objection to using string< in our similar features.
Ah, OK, then the change is good.
John
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master 9145e79: * lisp/files.el: Don't allow customization of dir-locals sorting
2015-11-10 14:16 ` [Emacs-diffs] master 9145e79: * lisp/files.el: Don't allow customization of dir-locals sorting John Wiegley
2015-11-10 15:49 ` Artur Malabarba
2015-11-10 16:32 ` Eli Zaretskii
@ 2015-11-11 0:37 ` Juri Linkov
2 siblings, 0 replies; 5+ messages in thread
From: Juri Linkov @ 2015-11-11 0:37 UTC (permalink / raw)
To: emacs-devel; +Cc: Eli Zaretskii, Artur Malabarba
>> In retrospect, this is not a good idea for the same reason that
>> `dir-locals-file' is a defconst, because it is important that this
>> behaviour be "uniform across different environments and users".
>> Sure, the user can still change the sorting with a hack, but we
>> shouldn't encourage them to change it.
>
> I'm inclined to agree with this; but did you mention it to Eli also, who had
> suggested using version<? I think string< is the right behavior, but since we
> had discussed it, I'd like to hear from him too.
As long as we implement the same globbing as shells do,
I agree that string< is more appropriate than version<.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-11-11 0:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151110122714.8693.7725@vcs.savannah.gnu.org>
[not found] ` <E1Zw815-0002Gt-E0@vcs.savannah.gnu.org>
2015-11-10 14:16 ` [Emacs-diffs] master 9145e79: * lisp/files.el: Don't allow customization of dir-locals sorting John Wiegley
2015-11-10 15:49 ` Artur Malabarba
2015-11-10 16:32 ` Eli Zaretskii
2015-11-10 16:34 ` John Wiegley
2015-11-11 0:37 ` Juri Linkov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.