all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Joost Kremers <joostkremers@fastmail.fm>
To: martin rudalics <rudalics@gmx.at>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: split-window-right doesn't work with wide margins
Date: Fri, 22 Jan 2016 10:31:26 +0100	[thread overview]
Message-ID: <874me6kljl.fsf@fastmail.fm> (raw)
In-Reply-To: <569FE37D.1050406@gmx.at>


On Wed, Jan 20 2016, martin rudalics <rudalics@gmx.at> wrote:
> Now we have two choices: Either we do count margins in this function.
> Then ‘split-window’ will fail as indicated in this report.  Or we do not
> count them.  Then we will have to automatically cut margins down as we
> did previously.

May I ask what the rationale for this change of behaviour was? (I
scanned the thread discussing your patch but I didn't see any mention of
it.)

>  This will, however, affect user-set margins that are
> _not_ continuously refreshed via a hook.

Does that happen? Users setting window margins, I mean?

> No.  ‘split-window-preferred-function’ only affects ‘display-buffer’.
> It does not affect ‘split-window’.  I attached a possible solution which
> is far from ideal.  I hope you get the idea.  A similar solution would
> be needed for ‘split-window-preferred-function’.  Essentially you would
> have to rewrite ‘split-window-sensibly’ with a reset/restore mechanism
> around the (window-splittable-p window t) and (split-window-right)
> forms.  Slightly more tricky ...

I'll take a closer look at it next week, when I have more time. 

> Sooner or later we should find a way to dynamically insert some stretch
> space on the left and right of a window body without affecting the value
> of ‘window-margins’.

Yes, that would be ideal.

-- 
Joost Kremers
Life has its moments



  reply	other threads:[~2016-01-22  9:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18  9:31 split-window-right doesn't work with wide margins Joost Kremers
2016-01-18 10:30 ` martin rudalics
2016-01-20 12:58   ` Joost Kremers
2016-01-20 19:43     ` martin rudalics
2016-01-22  9:31       ` Joost Kremers [this message]
2016-01-22 11:05         ` martin rudalics
2016-03-01 15:48       ` Joost Kremers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874me6kljl.fsf@fastmail.fm \
    --to=joostkremers@fastmail.fm \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.