From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: member inconsistency? Date: Thu, 28 Jan 2016 23:18:29 +0100 Message-ID: <874mdxz6tm.fsf@igel.home> References: <87twly2iye.fsf@nicolasgoaziou.fr> <871t929f1e.fsf@gmx.net> <83bn85zovm.fsf@gnu.org> <87wpqt8vdv.fsf@gmx.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1454019547 6694 80.91.229.3 (28 Jan 2016 22:19:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Jan 2016 22:19:07 +0000 (UTC) Cc: Eli Zaretskii , p.stephani2@gmail.com, mail@nicolasgoaziou.fr, emacs-devel@gnu.org To: Stephen Berman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 28 23:18:58 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aOuu0-0000qu-6c for ged-emacs-devel@m.gmane.org; Thu, 28 Jan 2016 23:18:56 +0100 Original-Received: from localhost ([::1]:58866 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOutz-0003N0-4H for ged-emacs-devel@m.gmane.org; Thu, 28 Jan 2016 17:18:55 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOutl-0003Mp-Lq for emacs-devel@gnu.org; Thu, 28 Jan 2016 17:18:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOutk-0002PP-Qe for emacs-devel@gnu.org; Thu, 28 Jan 2016 17:18:41 -0500 Original-Received: from mx2.suse.de ([195.135.220.15]:49433) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOutg-0002LT-6J; Thu, 28 Jan 2016 17:18:36 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Original-Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0BCB0AC01; Thu, 28 Jan 2016 22:18:31 +0000 (UTC) X-Yow: AIEEEEE! I am having an UNDULATING EXPERIENCE! In-Reply-To: <87wpqt8vdv.fsf@gmx.net> (Stephen Berman's message of "Thu, 28 Jan 2016 18:30:04 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 195.135.220.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198959 Archived-At: Stephen Berman writes: > diff --git a/src/fns.c b/src/fns.c > index 86ad333..17c4a75 100644 > --- a/src/fns.c > +++ b/src/fns.c > @@ -1349,7 +1349,7 @@ The value is actually the tail of LIST whose car is ELT. */) > (register Lisp_Object elt, Lisp_Object list) > { > register Lisp_Object tail; > - for (tail = list; CONSP (tail); tail = XCDR (tail)) > + for (tail = list; CONSP (tail) || !NILP (tail); tail = XCDR (tail)) > { > register Lisp_Object tem; > CHECK_LIST_CONS (tail, list); The check for CONSP in the loop condition is redundant, that is already checked by CHECK_LIST_CONS (and the latter was a no-op before). Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."