all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: Eli Zaretskii <eliz@gnu.org>,
	p.stephani2@gmail.com, mail@nicolasgoaziou.fr,
	emacs-devel@gnu.org
Subject: Re: member inconsistency?
Date: Thu, 28 Jan 2016 23:18:29 +0100	[thread overview]
Message-ID: <874mdxz6tm.fsf@igel.home> (raw)
In-Reply-To: <87wpqt8vdv.fsf@gmx.net> (Stephen Berman's message of "Thu, 28 Jan 2016 18:30:04 +0100")

Stephen Berman <stephen.berman@gmx.net> writes:

> diff --git a/src/fns.c b/src/fns.c
> index 86ad333..17c4a75 100644
> --- a/src/fns.c
> +++ b/src/fns.c
> @@ -1349,7 +1349,7 @@ The value is actually the tail of LIST whose car is ELT.  */)
>    (register Lisp_Object elt, Lisp_Object list)
>  {
>    register Lisp_Object tail;
> -  for (tail = list; CONSP (tail); tail = XCDR (tail))
> +  for (tail = list; CONSP (tail) || !NILP (tail); tail = XCDR (tail))
>      {
>        register Lisp_Object tem;
>        CHECK_LIST_CONS (tail, list);

The check for CONSP in the loop condition is redundant, that is already
checked by CHECK_LIST_CONS (and the latter was a no-op before).

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."



  parent reply	other threads:[~2016-01-28 22:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28  8:42 member inconsistency? Nicolas Goaziou
2016-01-28  9:41 ` Philipp Stephani
2016-01-28 10:14   ` Andreas Schwab
2016-01-28 10:25     ` Stephen Berman
2016-01-28 15:48       ` Eli Zaretskii
2016-01-28 17:30         ` Stephen Berman
2016-01-28 18:35           ` Eli Zaretskii
2016-01-28 21:57             ` Stephen Berman
2016-01-28 22:18           ` Andreas Schwab [this message]
2016-01-28 22:41             ` Stephen Berman
2016-01-28 23:38       ` Johan Bockgård
2016-01-28 23:57         ` Stephen Berman
2016-01-29 10:25           ` Andreas Schwab
2016-01-29 11:20             ` Stephen Berman
2016-01-29 14:15             ` Eli Zaretskii
2016-01-29 19:17               ` John Wiegley
2016-01-29 23:58         ` Richard Stallman
2016-02-01  7:10           ` Fabrice Popineau
2016-02-01 11:04             ` Richard Stallman
2016-02-01 12:20               ` Fabrice Popineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mdxz6tm.fsf@igel.home \
    --to=schwab@suse.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --cc=p.stephani2@gmail.com \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.