all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] master f6d71b5 2/2: Fix compilation warnings in gnus-art.el
       [not found] ` <E1aUSIL-0006Qu-Pn@vcs.savannah.gnu.org>
@ 2016-02-13 13:13   ` Stefan Monnier
  2016-02-14  1:58     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2016-02-13 13:13 UTC (permalink / raw)
  To: emacs-devel; +Cc: Lars Ingebrigtsen

> +(autoload 'rfc1843-decode-region "rfc1843")

Bad idea.

>  (defun article-decode-HZ ()
>    "Translate a HZ-encoded article."
>    (interactive)
> -  (require 'rfc1843)

Better keep this require, and replace the above autoload with
a `declare-function'.  Or else move the require to top-level.  Or mark
rfc1843-decode-region as autoloaded.


        Stefan



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Emacs-diffs] master f6d71b5 2/2: Fix compilation warnings in gnus-art.el
  2016-02-13 13:13   ` [Emacs-diffs] master f6d71b5 2/2: Fix compilation warnings in gnus-art.el Stefan Monnier
@ 2016-02-14  1:58     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2016-02-14  1:58 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> +(autoload 'rfc1843-decode-region "rfc1843")
>
> Bad idea.
>
>>  (defun article-decode-HZ ()
>>    "Translate a HZ-encoded article."
>>    (interactive)
>> -  (require 'rfc1843)
>
> Better keep this require, and replace the above autoload with
> a `declare-function'.  Or else move the require to top-level.  Or mark
> rfc1843-decode-region as autoloaded.

Oh, yeah, I meant to do a `declare-function' there.  I'll fix it...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-14  1:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20160213045839.24281.16174@vcs.savannah.gnu.org>
     [not found] ` <E1aUSIL-0006Qu-Pn@vcs.savannah.gnu.org>
2016-02-13 13:13   ` [Emacs-diffs] master f6d71b5 2/2: Fix compilation warnings in gnus-art.el Stefan Monnier
2016-02-14  1:58     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.