From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Marcin Borkowski Newsgroups: gmane.emacs.bugs Subject: bug#18157: 24.4.50; battery-pmset fails to report critical battery state Date: Tue, 16 Feb 2016 15:56:56 +0100 Message-ID: <874md81z5z.fsf@amu.edu.pl> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1455634730 15098 80.91.229.3 (16 Feb 2016 14:58:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Feb 2016 14:58:50 +0000 (UTC) Cc: mbork@mbork.pl, 18157@debbugs.gnu.org To: Sebastian Wiesner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 16 15:58:41 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aVh4v-0007Lu-0T for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Feb 2016 15:58:13 +0100 Original-Received: from localhost ([::1]:46816 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVh4u-0003EC-8I for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Feb 2016 09:58:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVh4p-0003BX-NM for bug-gnu-emacs@gnu.org; Tue, 16 Feb 2016 09:58:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVh4k-00075j-8H for bug-gnu-emacs@gnu.org; Tue, 16 Feb 2016 09:58:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVh4k-00075f-49 for bug-gnu-emacs@gnu.org; Tue, 16 Feb 2016 09:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aVh4j-0006lO-ST for bug-gnu-emacs@gnu.org; Tue, 16 Feb 2016 09:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Marcin Borkowski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Feb 2016 14:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18157 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18157-submit@debbugs.gnu.org id=B18157.145563462925932 (code B ref 18157); Tue, 16 Feb 2016 14:58:01 +0000 Original-Received: (at 18157) by debbugs.gnu.org; 16 Feb 2016 14:57:09 +0000 Original-Received: from localhost ([127.0.0.1]:42062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVh3s-0006kC-P0 for submit@debbugs.gnu.org; Tue, 16 Feb 2016 09:57:08 -0500 Original-Received: from mail.mojserwer.eu ([195.110.48.8]:37794) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVh3q-0006k3-8k for 18157@debbugs.gnu.org; Tue, 16 Feb 2016 09:57:06 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 86C189D2002; Tue, 16 Feb 2016 15:57:05 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Original-Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pgvrG6cEw5TG; Tue, 16 Feb 2016 15:56:59 +0100 (CET) Original-Received: from localhost (unknown [IPv6:2001:808:114:6:a288:b4ff:fe90:5e24]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 74ED29D2001; Tue, 16 Feb 2016 15:56:59 +0100 (CET) In-Reply-To: (Sebastian Wiesner's message of "Thu, 31 Jul 2014 15:16:44 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113132 Archived-At: On 2014-07-31, at 16:16, Sebastian Wiesner wrote: > `battery-pmset' fails to correctly report critical battery state: Even > if the battery charge level is below `battery-load-critical', it reports > "low" battery state only. > > The culprit is the `cond' expression in the body of `battery-pmset' > which compares the reported `load-percentage' against `battery-load-low' > first, and then against `battery-load-critical'. > > Since the latter is typically lower, it will never be reached, because > `cond' already returns after the former succeeded. > > To fix this issue, `batter-pmset' needs to check `battery-load-critical' > *first*, and then `battery-load-low'. Does this patch help? --8<---------------cut here---------------start------------->8--- diff -u --label /usr/local/share/emacs/25.1.50/lisp/battery.el.gz --label \#\ /tmp/jka-com1889YvM /tmp/buffer-content-1889yDZ --- /usr/local/share/emacs/25.1.50/lisp/battery.el.gz +++ # @@ -628,12 +628,12 @@ (cond ((looking-at "; charging") (setq battery-status "charging" battery-status-symbol "+")) - ((< (string-to-number load-percentage) battery-load-low) - (setq battery-status "low" - battery-status-symbol "-")) ((< (string-to-number load-percentage) battery-load-critical) (setq battery-status "critical" battery-status-symbol "!")) + ((< (string-to-number load-percentage) battery-load-low) + (setq battery-status "low" + battery-status-symbol "-")) (t (setq battery-status "high" battery-status-symbol ""))) Diff finished. Tue Feb 16 15:56:03 2016 --8<---------------cut here---------------end--------------->8--- Best, -- mb