From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#22736: 25.0.91; file-notify calls wrong callbacks Date: Fri, 19 Feb 2016 23:59:42 +0100 Message-ID: <874md4z4pt.fsf@gnu.org> References: <877fi1x2k7.fsf@gnu.org> <83a8mxu6fl.fsf@gnu.org> <87d1rt5bpc.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1455922821 13049 80.91.229.3 (19 Feb 2016 23:00:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Feb 2016 23:00:21 +0000 (UTC) Cc: 22736@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 20 00:00:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aWu1x-0007Ne-Mg for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Feb 2016 00:00:09 +0100 Original-Received: from localhost ([::1]:55979 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWu1x-00028Z-7P for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Feb 2016 18:00:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWu1u-00026Z-2f for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2016 18:00:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWu1q-0001M6-TU for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2016 18:00:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWu1q-0001Ln-Qt for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2016 18:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aWu1q-0005Es-LC for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2016 18:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Feb 2016 23:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22736 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22736-submit@debbugs.gnu.org id=B22736.145592278620082 (code B ref 22736); Fri, 19 Feb 2016 23:00:02 +0000 Original-Received: (at 22736) by debbugs.gnu.org; 19 Feb 2016 22:59:46 +0000 Original-Received: from localhost ([127.0.0.1]:34349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWu1a-0005Dq-84 for submit@debbugs.gnu.org; Fri, 19 Feb 2016 17:59:46 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52586) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWu1Z-0005Dj-G2 for 22736@debbugs.gnu.org; Fri, 19 Feb 2016 17:59:45 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1A07F20956 for <22736@debbugs.gnu.org>; Fri, 19 Feb 2016 17:59:45 -0500 (EST) Original-Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 19 Feb 2016 17:59:45 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=cdV0glGx+H+fSGXitklcOT2P4Yw=; b=CSvq6 DXuOob/ge71Yi3V7Wa0Ard5flM3wfiVPfjU2A5Q5a4EuXrXT9ucCfWGM8GaiDQNV mNQlRPmUDVDCBi50bfSJxKVQhNDG1wH0GcMBi8IiwIp3SaC+e1UMhdx/lOPAxxCn Ds6q2SbMAs3AFa3a3jytsGDs6ap5M6dP0dO1rc= X-Sasl-enc: ANJoL+sVXJQcnJ3FoiIEHHNDWzGd/sIf+FaJbhh+ctFF 1455922784 Original-Received: from thinkpad-t440p (unknown [31.213.65.129]) by mail.messagingengine.com (Postfix) with ESMTPA id 4729CC0001B; Fri, 19 Feb 2016 17:59:44 -0500 (EST) In-Reply-To: <87d1rt5bpc.fsf@gmx.de> (Michael Albinus's message of "Fri, 19 Feb 2016 09:46:55 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.91 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113320 Archived-At: Michael Albinus writes: Hi Michael and Eli, >>> The problem is that when there is a directory watch on some >>> directory and a file watch on a file in that directory, the callback >>> for the directory watch gets an event with the descriptor of the >>> file watch. >> >> I think this is because when you ask to watch a file, we actually >> watch its parent directory. > > Although we watch the parent directory internally (except with > kqueue), the given scenario by Tassilo shall work as he expected. > There shall be two file notification events in the given case, calling > magit-filenotify--callback and auto-revert-notify-handler with the > respective descriptor. Yes, that's exactly what I had expected. > I'll check. Thanks! > Tassilo, would you be willing to write an ert test case for the problem? Sure, I'm already working on it. :-) Bye, Tassilo