From: Michael Albinus <michael.albinus@gmx.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 22814@debbugs.gnu.org, andlind@gmail.com
Subject: bug#22814: 25.0.91; Emacs runs out of file descriptors on OS X
Date: Fri, 04 Mar 2016 08:53:24 +0100 [thread overview]
Message-ID: <874mcm7k7f.fsf@gmx.de> (raw)
In-Reply-To: <831t7s7tsg.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 02 Mar 2016 18:01:51 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
Hi Eli,
>> Indeed, Emacs tries to read the docstring of the just fetched
>> function. And it tries to open etc/DOC for this, which fails due to the
>> missing file descriptor availability.
>>
>> I don't believe we need to handle this case; if Emacs is running out of
>> file descriptors, anything could happen.
>
> The only part that might be worth improving is the error message: it's
> a far cry from what really went wrong. If you can find a way of
> making it say something about "too many open files", that'd be all the
> improvement we can hope for.
I would apply the following patch:
--8<---------------cut here---------------start------------->8---
*** /home/albinus/src/emacs-25/src/doc.c.~2e78353fabe11c768627c50e48375de5693ce7ee~
--- /home/albinus/src/emacs-25/src/doc.c
***************
*** 126,131 ****
--- 126,134 ----
fd = emacs_open (name, O_RDONLY, 0);
if (fd < 0)
{
+ if ((errno == EMFILE) || (errno == ENFILE))
+ report_file_error ("Read error on documentation file", file);
+
#ifndef CANNOT_DUMP
if (!NILP (Vpurify_flag))
{
--8<---------------cut here---------------end--------------->8---
This ends up in the following error message:
Read error on documentation file: Too many open files, /home/albinus/src/emacs-25/lisp/emacs-lisp/cl-seq.elc
Is it OK to apply it to the emacs-25 branch, or shall it go to master?
Best regards, Michael.
next prev parent reply other threads:[~2016-03-04 7:53 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 6:18 bug#22814: 25.0.91; Emacs runs out of file descriptors on OS X David Caldwell
2016-02-26 8:34 ` Michael Albinus
2016-02-26 9:05 ` David Caldwell
2016-02-26 10:26 ` Nicolas Richard
2016-02-26 9:22 ` Eli Zaretskii
2016-02-26 20:05 ` Michael Albinus
2016-02-26 9:04 ` Eli Zaretskii
2016-02-26 20:51 ` Anders Lindgren
2016-02-27 8:00 ` Michael Albinus
2016-02-27 9:19 ` Eli Zaretskii
2016-02-27 13:26 ` Michael Albinus
2016-02-27 19:00 ` Anders Lindgren
2016-02-27 19:12 ` Michael Albinus
2016-02-27 19:17 ` Eli Zaretskii
2016-02-27 19:33 ` Michael Albinus
2016-02-27 19:39 ` Eli Zaretskii
2016-02-27 19:51 ` Michael Albinus
2016-02-27 19:58 ` Eli Zaretskii
2016-02-27 20:06 ` Michael Albinus
2016-02-27 20:25 ` Eli Zaretskii
2016-02-28 9:57 ` Michael Albinus
2016-02-28 15:51 ` Eli Zaretskii
2016-02-27 19:14 ` Eli Zaretskii
2016-02-27 19:26 ` Michael Albinus
2016-02-27 19:36 ` Eli Zaretskii
2016-02-27 19:39 ` Michael Albinus
2016-02-27 19:56 ` Michael Albinus
2016-02-27 20:06 ` Eli Zaretskii
2016-02-29 10:24 ` Michael Albinus
2016-02-29 16:02 ` Eli Zaretskii
2016-03-02 15:03 ` Michael Albinus
2016-03-02 16:01 ` Eli Zaretskii
2016-03-04 7:53 ` Michael Albinus [this message]
2016-03-04 8:14 ` John Wiegley
2016-03-04 8:29 ` Eli Zaretskii
2016-03-04 14:05 ` Michael Albinus
2016-03-04 14:11 ` Michael Albinus
2016-04-10 8:21 ` Michael Albinus
2016-04-10 20:37 ` Anders Lindgren
2016-04-11 6:40 ` Michael Albinus
2016-04-11 6:48 ` Anders Lindgren
2016-04-11 6:58 ` Michael Albinus
2016-04-11 18:59 ` Anders Lindgren
2016-04-12 7:44 ` Michael Albinus
2016-02-27 9:55 ` Anders Lindgren
2016-02-27 10:46 ` Eli Zaretskii
2016-02-27 11:38 ` Anders Lindgren
2016-02-27 12:17 ` Michael Albinus
2016-02-27 12:40 ` Eli Zaretskii
2016-02-27 12:49 ` Michael Albinus
2016-02-27 12:52 ` Eli Zaretskii
2016-02-27 13:00 ` Michael Albinus
2016-03-05 0:32 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mcm7k7f.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=22814@debbugs.gnu.org \
--cc=andlind@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.