From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#22829: Acknowledgement (25.1.50; Display number of marked files) Date: Mon, 07 Mar 2016 02:04:55 +0200 Organization: LINKOV.NET Message-ID: <874mcjjfs8.fsf@mail.linkov.net> References: <87mvqlv1h4.fsf@gnus.org> <87fuw9203w.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1457310624 5660 80.91.229.3 (7 Mar 2016 00:30:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Mar 2016 00:30:24 +0000 (UTC) Cc: 22829@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 07 01:30:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1acj3p-0008DE-Fy for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Mar 2016 01:30:09 +0100 Original-Received: from localhost ([::1]:52712 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acj3o-0004de-P3 for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Mar 2016 19:30:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53410) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acj3k-0004aQ-3S for bug-gnu-emacs@gnu.org; Sun, 06 Mar 2016 19:30:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acj3j-0002na-5o for bug-gnu-emacs@gnu.org; Sun, 06 Mar 2016 19:30:04 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acj3j-0002n5-3L for bug-gnu-emacs@gnu.org; Sun, 06 Mar 2016 19:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1acj3i-00063j-NL for bug-gnu-emacs@gnu.org; Sun, 06 Mar 2016 19:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Mar 2016 00:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22829 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22829-submit@debbugs.gnu.org id=B22829.145731056523224 (code B ref 22829); Mon, 07 Mar 2016 00:30:02 +0000 Original-Received: (at 22829) by debbugs.gnu.org; 7 Mar 2016 00:29:25 +0000 Original-Received: from localhost ([127.0.0.1]:37149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1acj36-00062W-Uz for submit@debbugs.gnu.org; Sun, 06 Mar 2016 19:29:25 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:59838 helo=homiemail-a17.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1acj35-00062O-By for 22829@debbugs.gnu.org; Sun, 06 Mar 2016 19:29:23 -0500 Original-Received: from homiemail-a17.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a17.g.dreamhost.com (Postfix) with ESMTP id 7AFAA2B206A; Sun, 6 Mar 2016 16:29:21 -0800 (PST) Original-Received: from localhost.linkov.net (62.65.224.79.cable.starman.ee [62.65.224.79]) (Authenticated sender: jurta@jurta.org) by homiemail-a17.g.dreamhost.com (Postfix) with ESMTPA id ABEAC2B2065; Sun, 6 Mar 2016 16:29:20 -0800 (PST) In-Reply-To: (Tino Calancha's message of "Thu, 3 Mar 2016 18:58:40 +0900 (JST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.91 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114524 Archived-At: > I have included the subdir sizes as an option: currently the subdir sizes are > not computed by default. We can change this behaviour to the opposite, > with subdir sizes computed by default, after the code being well tested. Thank you! I have a feeling that code could be optimized more before installing to dired. I'll check it to estimate how well it works. One quick comment: in defcustom my-dired-used-space-program you could find if an executable exists like: (defcustom my-dired-used-space-program (and (executable-find "du") du") For more examples, please see defcustom dired-chown-program or defcustom archive-zip-extract how to define a command with its arguments in one defcustom. > There are two functions doing the same thing: > * my-dired-count-sizes-opt1: > * my-dired-count-sizes-opt2: This looks nicer but it requires cl-lib. dired-aux.el already includes (require 'cl-lib) - twice (just in case :), so there is no problem in using 'cl-lib.