From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: handa Newsgroups: gmane.emacs.bugs Subject: bug#21846: 25.0.50; emacs hebrew script bidi nikud rendering bug Date: Mon, 21 Mar 2016 23:56:49 +0900 Message-ID: <874mbzubf2.fsf@gnu.org> References: <87y4eag3s8.fsf@ubuntu.i-did-not-set--mail-host-address--so-tickle-me> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1458572305 18990 80.91.229.3 (21 Mar 2016 14:58:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Mar 2016 14:58:25 +0000 (UTC) Cc: 21846@debbugs.gnu.org, mhd@yv.org, b.riefenstahl@turtle-trading.net To: Wolfgang Jenkner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 21 15:58:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ai1HX-0007Lc-AI for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 15:58:11 +0100 Original-Received: from localhost ([::1]:58286 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai1HW-0002pV-SF for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 10:58:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai1HT-0002pO-1b for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 10:58:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai1HO-0003RZ-8O for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 10:58:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai1HO-0003RU-6E for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 10:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ai1HO-00077f-0N for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 10:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: handa Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Mar 2016 14:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21846 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21846-submit@debbugs.gnu.org id=B21846.145857223827310 (code B ref 21846); Mon, 21 Mar 2016 14:58:01 +0000 Original-Received: (at 21846) by debbugs.gnu.org; 21 Mar 2016 14:57:18 +0000 Original-Received: from localhost ([127.0.0.1]:57067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai1Gf-00076Q-OU for submit@debbugs.gnu.org; Mon, 21 Mar 2016 10:57:17 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:32890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai1Ge-00076C-Ny for 21846@debbugs.gnu.org; Mon, 21 Mar 2016 10:57:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai1GT-0003L9-W6 for 21846@debbugs.gnu.org; Mon, 21 Mar 2016 10:57:11 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai1GK-0003Kf-4k; Mon, 21 Mar 2016 10:56:56 -0400 Original-Received: from fl1-110-233-34-83.iba.mesh.ad.jp ([110.233.34.83]:55196 helo=shatin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ai1GJ-0003Cp-EK; Mon, 21 Mar 2016 10:56:55 -0400 Original-Received: from handa by shatin with local (Exim 4.86) (envelope-from ) id 1ai1GD-0004xs-Hs; Mon, 21 Mar 2016 23:56:49 +0900 In-Reply-To: <85pourn5g9.fsf@inode.at> (message from Wolfgang Jenkner on Fri, 18 Mar 2016 16:56:23 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115229 Archived-At: In article <85pourn5g9.fsf@inode.at>, Wolfgang Jenkner = writes: > These changes (536f48e, 9835757, resp. the backports to emacs-25, viz. > 4a3db0f, ad879b7) seem to break rendering of some Indic scripts. > Conjuncts are not composed anymore but rendered with vir=C4=81ma instead. > E.g., please see the Hindi entry of the HELLO file. > Apparently, the reason is this change > - if (0x300 <=3D c1 && c1 <=3D 0x36F) > + if (CHAR_HAS_CATEGORY (c1, '^')) > as, say, "DEVANAGARI SIGN VIRAMA" is excluded by the old condition but > included by the new one: Oops, right. Have about this change? --- K. Handa handa@gnu.org 2016-03-21 handa * ftfont.c (ftfont_shape_by_flt): For combining characters out of the range U+300...U+36F, use the "combining" FLT only with non-OTF fonts. diff --git a/src/ftfont.c b/src/ftfont.c index 505d508..17ccda4 100644 --- a/src/ftfont.c +++ b/src/ftfont.c @@ -2596,7 +2596,12 @@ ftfont_shape_by_flt (Lisp_Object lgstring, struct fo= nt *font, language information, and select a proper flt for them here. */ int c1 =3D LGLYPH_CHAR (LGSTRING_GLYPH (lgstring, 1)); - if (CHAR_HAS_CATEGORY (c1, '^')) + /* For the combining characters in the range U+300..U+36F, + "combining" is the sole FLT provided by the m17n-lib. In + addition, it is the sole FLT that can handle the other + combining characters with non-OTF fonts. */ + if (0x300 <=3D c1 && c1 <=3D 0x36F + || (! otf && CHAR_HAS_CATEGORY (c1, '^'))) flt =3D mflt_get (msymbol ("combining")); } if (! flt && ! otf)