From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?=C3=93scar?= Fuentes Newsgroups: gmane.emacs.bugs Subject: bug#23075: 24.5; vc-git-command should use coding-system-for-read Date: Mon, 21 Mar 2016 20:38:22 +0100 Message-ID: <874mbzfwpd.fsf@wanadoo.es> References: <56EFD97C.3080805@gmail.com> <83wpov6c35.fsf@gnu.org> <87d1qng4aj.fsf@wanadoo.es> <87egb3r9wc.fsf@linux-m68k.org> <878u1bg10o.fsf@wanadoo.es> <83io0f669g.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1458589164 12210 80.91.229.3 (21 Mar 2016 19:39:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Mar 2016 19:39:24 +0000 (UTC) Cc: schwab@linux-m68k.org, 23075@debbugs.gnu.org, nikolay.kudryavtsev@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 21 20:39:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ai5fT-0005ZI-QX for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 20:39:11 +0100 Original-Received: from localhost ([::1]:59968 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai5fT-00018F-46 for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 15:39:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai5fP-000188-3h for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 15:39:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai5fK-0002Sd-Oo for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 15:39:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai5fK-0002SZ-LT for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 15:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ai5fK-0007Ba-Gv for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 15:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=C3=93scar?= Fuentes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Mar 2016 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23075 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23075-submit@debbugs.gnu.org id=B23075.145858911427589 (code B ref 23075); Mon, 21 Mar 2016 19:39:02 +0000 Original-Received: (at 23075) by debbugs.gnu.org; 21 Mar 2016 19:38:34 +0000 Original-Received: from localhost ([127.0.0.1]:57332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai5es-0007Av-4y for submit@debbugs.gnu.org; Mon, 21 Mar 2016 15:38:34 -0400 Original-Received: from smtp10.acens.net ([86.109.99.134]:27605 helo=smtp.movistar.es) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai5ep-0007Ad-9r for 23075@debbugs.gnu.org; Mon, 21 Mar 2016 15:38:32 -0400 X-CTCH-RefID: str=0001.0A0B0201.56F04DAF.00B5, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown Original-Received: from qcore (79.153.146.151) by smtp.movistar.es (8.6.122.03) (authenticated as 981711563$telefonica.net) id 56E759CD0079A847; Mon, 21 Mar 2016 19:38:23 +0000 In-Reply-To: <83io0f669g.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 21 Mar 2016 20:22:03 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.92 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115267 Archived-At: Eli Zaretskii writes: >> Does git always use that encoding? If not, on what it depends the >> encoding used by git? > > It just spews the bytes, AFAIK. IOW, it's the encoding of the file > whose log we are viewing. I was expecting from HELLO to be utf-8, but you are right. Please note that a diff may contain changes from multiple files, including some that do not longer exists (or that exists with another encoding). So we can't process a diff as a single unit, it must be separated by file. Solving this on a general way does not seem possible, but we can do our best by using the file's current encoding, or simply guessing it. The former can have serious performance implications.