* Re: master 326fff4: Improve w32notify notifications [not found] ` <E1ahGGo-0007GB-7z@vcs.savannah.gnu.org> @ 2016-03-19 15:11 ` Michael Albinus 2016-03-21 6:03 ` Fabrice Popineau 0 siblings, 1 reply; 9+ messages in thread From: Michael Albinus @ 2016-03-19 15:11 UTC (permalink / raw) To: Fabrice Popineau; +Cc: emacs-devel Hi Fabrice, > diff --git a/test/lisp/filenotify-tests.el b/test/lisp/filenotify-tests.el > index d3610f0..3908894 100644 > --- a/test/lisp/filenotify-tests.el > +++ b/test/lisp/filenotify-tests.el > @@ -754,7 +757,9 @@ longer than timeout seconds for the events to be delivered." > (should (file-notify-valid-p file-notify--test-desc)) > ;; After removing the watch, the descriptor must not be valid > ;; anymore. > + (read-event nil nil file-notify--test-read-event-timeout) > (file-notify-rm-watch file-notify--test-desc) > + (read-event nil nil file-notify--test-read-event-timeout) > (file-notify--wait-for-events > (file-notify--test-timeout) > (not (file-notify-valid-p file-notify--test-desc))) > @@ -776,7 +781,9 @@ longer than timeout seconds for the events to be delivered." > (should (file-notify-valid-p file-notify--test-desc)) > ;; After deleting the directory, the descriptor must not be > ;; valid anymore. > + (read-event nil nil file-notify--test-read-event-timeout) > (delete-directory file-notify--test-tmpfile t) > + (read-event nil nil file-notify--test-read-event-timeout) > (file-notify--wait-for-events > (file-notify--test-timeout) > (not (file-notify-valid-p file-notify--test-desc))) I'm curious why you need the additional `read-event' calls. The following `file-notify--wait-for-events' loops until the condition is satisfied, calling `read-event' every iteration. Best regards, Michael. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master 326fff4: Improve w32notify notifications 2016-03-19 15:11 ` master 326fff4: Improve w32notify notifications Michael Albinus @ 2016-03-21 6:03 ` Fabrice Popineau 2016-03-22 10:15 ` Michael Albinus 2016-03-29 14:31 ` Andy Moreton 0 siblings, 2 replies; 9+ messages in thread From: Fabrice Popineau @ 2016-03-21 6:03 UTC (permalink / raw) To: Michael Albinus; +Cc: Emacs developers [-- Attachment #1: Type: text/plain, Size: 1808 bytes --] 2016-03-19 16:11 GMT+01:00 Michael Albinus <michael.albinus@gmx.de>: > Hi Fabrice, > > > diff --git a/test/lisp/filenotify-tests.el > b/test/lisp/filenotify-tests.el > > index d3610f0..3908894 100644 > > --- a/test/lisp/filenotify-tests.el > > +++ b/test/lisp/filenotify-tests.el > > @@ -754,7 +757,9 @@ longer than timeout seconds for the events to be > delivered." > > (should (file-notify-valid-p file-notify--test-desc)) > > ;; After removing the watch, the descriptor must not be valid > > ;; anymore. > > + (read-event nil nil file-notify--test-read-event-timeout) > > (file-notify-rm-watch file-notify--test-desc) > > + (read-event nil nil file-notify--test-read-event-timeout) > > (file-notify--wait-for-events > > (file-notify--test-timeout) > > (not (file-notify-valid-p file-notify--test-desc))) > > @@ -776,7 +781,9 @@ longer than timeout seconds for the events to be > delivered." > > (should (file-notify-valid-p file-notify--test-desc)) > > ;; After deleting the directory, the descriptor must not be > > ;; valid anymore. > > + (read-event nil nil file-notify--test-read-event-timeout) > > (delete-directory file-notify--test-tmpfile t) > > + (read-event nil nil file-notify--test-read-event-timeout) > > (file-notify--wait-for-events > > (file-notify--test-timeout) > > (not (file-notify-valid-p file-notify--test-desc))) > > I'm curious why you need the additional `read-event' calls. The > following `file-notify--wait-for-events' loops until the condition is > satisfied, calling `read-event' every iteration. > > Oh ... sorry, yes, we should revert those read-event calls then. I added them mechanically, overlooking the macro. Fabrice [-- Attachment #2: Type: text/html, Size: 2449 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master 326fff4: Improve w32notify notifications 2016-03-21 6:03 ` Fabrice Popineau @ 2016-03-22 10:15 ` Michael Albinus [not found] ` <CAFgFV9OKWebjGRHrhysG+PCJuQH2vke8eYMbvr05ocQnscMVJg@mail.gmail.com> 2016-03-29 14:31 ` Andy Moreton 1 sibling, 1 reply; 9+ messages in thread From: Michael Albinus @ 2016-03-22 10:15 UTC (permalink / raw) To: Fabrice Popineau; +Cc: Emacs developers Fabrice Popineau <fabrice.popineau@gmail.com> writes: Hi Fabrice, > Oh ... sorry, yes, we should revert those read-event calls then. > I added them mechanically, overlooking the macro. I could revert them, running also full tests on w32. If you could provide me a compiled Emacs from master, again ... > Fabrice Best regards, Michael. ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <CAFgFV9OKWebjGRHrhysG+PCJuQH2vke8eYMbvr05ocQnscMVJg@mail.gmail.com>]
[parent not found: <87shzgqbd8.fsf@gmx.de>]
[parent not found: <CAFgFV9PE_zRF+ukD9X=k4pYogBEmB9cr=HRA0wig8yZXhgG8Jw@mail.gmail.com>]
* Re: master 326fff4: Improve w32notify notifications [not found] ` <CAFgFV9PE_zRF+ukD9X=k4pYogBEmB9cr=HRA0wig8yZXhgG8Jw@mail.gmail.com> @ 2016-03-24 13:16 ` Michael Albinus 2016-03-24 15:57 ` Eli Zaretskii 0 siblings, 1 reply; 9+ messages in thread From: Michael Albinus @ 2016-03-24 13:16 UTC (permalink / raw) To: Fabrice Popineau; +Cc: emacs-devel Fabrice Popineau <fabrice.popineau@gmail.com> writes: > This is the case for which I said I had a disagreement. > > Are you saying that you get 4 notifications where I get only 2 ? > In this case, that must be a difference between Windows 7 and Windows > 10, > but that is weird. Yes, I get 4 `changed' events. Running on 64-bit "Windows 7 Enterprise SP1". Hmm, what shall we do? Allow both variants, and document it in the test file? > Fabrice Best regards, Michael. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master 326fff4: Improve w32notify notifications 2016-03-24 13:16 ` Michael Albinus @ 2016-03-24 15:57 ` Eli Zaretskii 2016-03-24 17:36 ` Michael Albinus 0 siblings, 1 reply; 9+ messages in thread From: Eli Zaretskii @ 2016-03-24 15:57 UTC (permalink / raw) To: Michael Albinus; +Cc: fabrice.popineau, emacs-devel > From: Michael Albinus <michael.albinus@gmx.de> > Date: Thu, 24 Mar 2016 14:16:13 +0100 > Cc: emacs-devel@gnu.org > > Fabrice Popineau <fabrice.popineau@gmail.com> writes: > > > This is the case for which I said I had a disagreement. > > > > Are you saying that you get 4 notifications where I get only 2 ? > > In this case, that must be a difference between Windows 7 and Windows > > 10, > > but that is weird. > > Yes, I get 4 `changed' events. Running on 64-bit "Windows 7 Enterprise SP1". > > Hmm, what shall we do? Allow both variants, and document it in the test file? Yes, I think so. Thanks. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master 326fff4: Improve w32notify notifications 2016-03-24 15:57 ` Eli Zaretskii @ 2016-03-24 17:36 ` Michael Albinus 0 siblings, 0 replies; 9+ messages in thread From: Michael Albinus @ 2016-03-24 17:36 UTC (permalink / raw) To: Eli Zaretskii; +Cc: fabrice.popineau, emacs-devel Eli Zaretskii <eliz@gnu.org> writes: >> Hmm, what shall we do? Allow both variants, and document it in the test file? > > Yes, I think so. Done. > Thanks. Best regards, Michael. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master 326fff4: Improve w32notify notifications 2016-03-21 6:03 ` Fabrice Popineau 2016-03-22 10:15 ` Michael Albinus @ 2016-03-29 14:31 ` Andy Moreton 2016-04-02 9:41 ` Eli Zaretskii 1 sibling, 1 reply; 9+ messages in thread From: Andy Moreton @ 2016-03-29 14:31 UTC (permalink / raw) To: emacs-devel On Mon 21 Mar 2016, Fabrice Popineau wrote: > 2016-03-19 16:11 GMT+01:00 Michael Albinus <michael.albinus@gmx.de>: >> >> I'm curious why you need the additional `read-event' calls. The >> following `file-notify--wait-for-events' loops until the condition is >> satisfied, calling `read-event' every iteration. >> > Oh ... sorry, yes, we should revert those read-event calls then. > I added them mechanically, overlooking the macro. > > Fabrice Hi Fabrice, The master 326fff4 commit also broke the cygwin w32 (i.e. non-X11) build. The following trivial patch fixes it. AndyM diff --git a/src/w32xfns.c b/src/w32xfns.c index 9b633c4..9a10bf3 100644 --- a/src/w32xfns.c +++ b/src/w32xfns.c @@ -48,6 +48,7 @@ init_crit (void) when the input queue is empty, so make it a manual reset event. */ input_available = CreateEvent (NULL, TRUE, FALSE, NULL); +#if HAVE_W32NOTIFY /* Initialize the linked list of notifications sets that will be used to communicate between the watching worker threads and the main thread. */ @@ -60,6 +61,7 @@ init_crit (void) } else DebPrint(("Out of memory: can't initialize notifications sets.")); +#endif /* HAVE_W32NOTIFY */ #ifdef WINDOWSNT keyboard_handle = input_available; @@ -90,6 +92,7 @@ delete_crit (void) interrupt_handle = NULL; } +#if HAVE_W32NOTIFY if (notifications_set_head) { /* Free any remaining notifications set that could be left over. */ @@ -104,6 +107,7 @@ delete_crit (void) } } free (notifications_set_head); +#endif /* HAVE_W32NOTIFY */ } void ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: master 326fff4: Improve w32notify notifications 2016-03-29 14:31 ` Andy Moreton @ 2016-04-02 9:41 ` Eli Zaretskii 2016-04-02 19:52 ` Michael Albinus 0 siblings, 1 reply; 9+ messages in thread From: Eli Zaretskii @ 2016-04-02 9:41 UTC (permalink / raw) To: Andy Moreton; +Cc: emacs-devel > From: Andy Moreton <andrewjmoreton@gmail.com> > Date: Tue, 29 Mar 2016 15:31:38 +0100 > > Hi Fabrice, > > The master 326fff4 commit also broke the cygwin w32 (i.e. non-X11) > build. The following trivial patch fixes it. Thanks, pushed. (I wish someone would volunteer to install such trivial changes, though.) ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: master 326fff4: Improve w32notify notifications 2016-04-02 9:41 ` Eli Zaretskii @ 2016-04-02 19:52 ` Michael Albinus 0 siblings, 0 replies; 9+ messages in thread From: Michael Albinus @ 2016-04-02 19:52 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Andy Moreton, emacs-devel Eli Zaretskii <eliz@gnu.org> writes: Hi Eli, > Thanks, pushed. (I wish someone would volunteer to install such > trivial changes, though.) I would do, and I did in other cases, if I understand the patch. Unfortunately, src/w32xfns.c is out of my scope. And I fear I'm not the only one. Anyway, if I could help in whatever is trivial, just ping me. Best regards, Michael. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-04-02 19:52 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <20160319124618.27869.30424@vcs.savannah.gnu.org> [not found] ` <E1ahGGo-0007GB-7z@vcs.savannah.gnu.org> 2016-03-19 15:11 ` master 326fff4: Improve w32notify notifications Michael Albinus 2016-03-21 6:03 ` Fabrice Popineau 2016-03-22 10:15 ` Michael Albinus [not found] ` <CAFgFV9OKWebjGRHrhysG+PCJuQH2vke8eYMbvr05ocQnscMVJg@mail.gmail.com> [not found] ` <87shzgqbd8.fsf@gmx.de> [not found] ` <CAFgFV9PE_zRF+ukD9X=k4pYogBEmB9cr=HRA0wig8yZXhgG8Jw@mail.gmail.com> 2016-03-24 13:16 ` Michael Albinus 2016-03-24 15:57 ` Eli Zaretskii 2016-03-24 17:36 ` Michael Albinus 2016-03-29 14:31 ` Andy Moreton 2016-04-02 9:41 ` Eli Zaretskii 2016-04-02 19:52 ` Michael Albinus
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.