From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#23520: 25.0.93; find-feature-regexp : mismatch between docstring and default value. Date: Sat, 02 Jul 2016 17:24:02 -0400 Message-ID: <874m87hgy5.fsf@users.sourceforge.net> References: <864ma3sofu.fsf@ulb.ac.be> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1467494666 15425 80.91.229.3 (2 Jul 2016 21:24:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Jul 2016 21:24:26 +0000 (UTC) Cc: 23520@debbugs.gnu.org To: Nicolas Richard Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 02 23:24:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bJSOd-0005BJ-23 for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jul 2016 23:24:15 +0200 Original-Received: from localhost ([::1]:40186 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJSOc-0003zn-AK for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jul 2016 17:24:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJSOS-0003yI-Pq for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2016 17:24:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJSOQ-0006cW-QG for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2016 17:24:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJSOQ-0006cS-Mi for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2016 17:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bJSOQ-0002Ih-G7 for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2016 17:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Jul 2016 21:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23520 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23520-submit@debbugs.gnu.org id=B23520.14674946418836 (code B ref 23520); Sat, 02 Jul 2016 21:24:02 +0000 Original-Received: (at 23520) by debbugs.gnu.org; 2 Jul 2016 21:24:01 +0000 Original-Received: from localhost ([127.0.0.1]:34897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJSOO-0002IN-Ve for submit@debbugs.gnu.org; Sat, 02 Jul 2016 17:24:01 -0400 Original-Received: from mail-io0-f179.google.com ([209.85.223.179]:33311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJSON-0002I5-9g; Sat, 02 Jul 2016 17:23:59 -0400 Original-Received: by mail-io0-f179.google.com with SMTP id t74so126609354ioi.0; Sat, 02 Jul 2016 14:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7f5nQBemNd3mb7BcVhPlTA6h1iWzfXut6I7hkwGJRjI=; b=zXfYKRHoN7TyQ87budQZvzAX6rgYGi/zRmZMkLTe0o1S/FIqMc+RfZ+LiF95vhQTuA VCU+21ujU1QCKo1L45eWkjfjW46ay5cIr2OO0bK88FsrMGxwGlsqmbsfqrhL2AMqrdUS sRtMMPsqs9RABSDx6pLl6Y20L48It7ZKfYG8PFwptYG6yO/WSioqd3bLTTesr6s9zovX M5xbf/vo2Hqf7NEB/1S60lFZ12COM9cfzUK4VoS3efFBIfe1fogNlP2U6RQlWBnzw5EV UM5ZBg8viVHAwGc6U05/O0TGCHcMiSEUAg5EDhEdalJaTqqj7rv273L3VUiYHA90z2hC C1mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=7f5nQBemNd3mb7BcVhPlTA6h1iWzfXut6I7hkwGJRjI=; b=LPl25N+MSULCbP2a1QoIINK5HXJ4dc8iqaR+FkDeipjD64hNedumXnSqmvUxLYPAkj /z7z1B/OxQ3CAAg2eYH3p31uVER+A+rWZu2pycQgCrAFObnHiD/2N64saUaHwCkaV+B0 E4bULxAq2ifPX03VfE2yzzvBGTwFQj7f7nfGwLRmFghbw0+8SRVzU1zov3p5OePhR/15 8itAaPa15buccYAoQlcBNnDpQqw8XmRp1sZrgH1EdLxmRIo8jv73ETTNygtOW9gx1soZ 8W2fSSQ5xn3vOduJZeJIuCcD3MyaQMaNGceuZx9rEufGAvgtIalmF2MV4YuiAluuTz/K Ylmw== X-Gm-Message-State: ALyK8tLYF6BwqoSPEEy6+fRSUt/WnesZ/UczGd5oRt09pP1/CsFivV0NKWEkKkvKarSsUw== X-Received: by 10.107.47.214 with SMTP id v83mr3649188iov.154.1467494633640; Sat, 02 Jul 2016 14:23:53 -0700 (PDT) Original-Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id d126sm8744204iog.20.2016.07.02.14.23.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Jul 2016 14:23:52 -0700 (PDT) In-Reply-To: <864ma3sofu.fsf@ulb.ac.be> (Nicolas Richard's message of "Thu, 12 May 2016 09:52:37 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120309 Archived-At: --=-=-= Content-Type: text/plain tags 23520 patch severity 23520 minor quit Nicolas Richard writes: > The comment explains why there is no "%s" in the default value, but when > doing C-h v find-feature-regexp RET, it's puzzling to read "must contain > %s" and then the default value doesn't actually contain "%s". Right, so basically s/must/may? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Clarify-docstring-of-find-feature-regexp.patch Content-Description: patch >From 0c5d9afceeb2fc748aedc075560729dfd8f14b4e Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 2 Jul 2016 17:17:55 -0400 Subject: [PATCH v1] Clarify docstring of find-feature-regexp * lisp/emacs-lisp/find-func.el (find-feature-regexp): Explain that `%s' is optional (Bug #23520). --- lisp/emacs-lisp/find-func.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el index d2e10ea..43bcb42 100644 --- a/lisp/emacs-lisp/find-func.el +++ b/lisp/emacs-lisp/find-func.el @@ -103,7 +103,7 @@ find-face-regexp (defcustom find-feature-regexp (concat ";;; Code:") "The regexp used by `xref-find-definitions' when searching for a feature definition. -Note it must contain a `%s' at the place where `format' +Note it may contain up to one `%s' at the place where `format' should insert the feature name." ;; We search for ";;; Code" rather than (feature '%s) because the ;; former is near the start of the code, and the latter is very -- 2.8.0 --=-=-=--