From: npostavs@users.sourceforge.net
To: Nicolas Richard <youngfrog@members.fsf.org>
Cc: 23520@debbugs.gnu.org
Subject: bug#23520: 25.0.93; find-feature-regexp : mismatch between docstring and default value.
Date: Sat, 02 Jul 2016 17:24:02 -0400 [thread overview]
Message-ID: <874m87hgy5.fsf@users.sourceforge.net> (raw)
In-Reply-To: <864ma3sofu.fsf@ulb.ac.be> (Nicolas Richard's message of "Thu, 12 May 2016 09:52:37 +0200")
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
tags 23520 patch
severity 23520 minor
quit
Nicolas Richard <youngfrog@members.fsf.org> writes:
> The comment explains why there is no "%s" in the default value, but when
> doing C-h v find-feature-regexp RET, it's puzzling to read "must contain
> %s" and then the default value doesn't actually contain "%s".
Right, so basically s/must/may?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1055 bytes --]
From 0c5d9afceeb2fc748aedc075560729dfd8f14b4e Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Sat, 2 Jul 2016 17:17:55 -0400
Subject: [PATCH v1] Clarify docstring of find-feature-regexp
* lisp/emacs-lisp/find-func.el (find-feature-regexp): Explain that `%s'
is optional (Bug #23520).
---
lisp/emacs-lisp/find-func.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el
index d2e10ea..43bcb42 100644
--- a/lisp/emacs-lisp/find-func.el
+++ b/lisp/emacs-lisp/find-func.el
@@ -103,7 +103,7 @@ find-face-regexp
(defcustom find-feature-regexp
(concat ";;; Code:")
"The regexp used by `xref-find-definitions' when searching for a feature definition.
-Note it must contain a `%s' at the place where `format'
+Note it may contain up to one `%s' at the place where `format'
should insert the feature name."
;; We search for ";;; Code" rather than (feature '%s) because the
;; former is near the start of the code, and the latter is very
--
2.8.0
next prev parent reply other threads:[~2016-07-02 21:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 7:52 bug#23520: 25.0.93; find-feature-regexp : mismatch between docstring and default value Nicolas Richard
2016-07-02 21:24 ` npostavs [this message]
2016-07-03 14:18 ` Nicolas Richard
2016-07-09 21:47 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m87hgy5.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=23520@debbugs.gnu.org \
--cc=youngfrog@members.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.