From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#4655: 23.1.50; buffer-swap-text oddity Date: Sun, 10 Jul 2016 21:58:36 -0400 Message-ID: <874m7xgckz.fsf@users.sourceforge.net> References: <20091006184604.9A5B2EFE6F@sonic02.math.uni-bielefeld.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1468202368 7130 80.91.229.3 (11 Jul 2016 01:59:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 Jul 2016 01:59:28 +0000 (UTC) Cc: Markus Rost , Juanma Barranquero , 4655@debbugs.gnu.org, Stefan Monnier To: Lars Magne Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 11 03:59:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bMQV9-0008V8-J9 for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Jul 2016 03:59:15 +0200 Original-Received: from localhost ([::1]:57428 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMQV8-0002LY-BL for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Jul 2016 21:59:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMQV0-0002K8-Nc for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 21:59:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMQUv-0007sO-TW for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 21:59:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33443) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMQUv-0007sK-PU for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 21:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bMQUv-0006vN-Jt for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 21:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jul 2016 01:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4655 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 4655-submit@debbugs.gnu.org id=B4655.146820233726607 (code B ref 4655); Mon, 11 Jul 2016 01:59:01 +0000 Original-Received: (at 4655) by debbugs.gnu.org; 11 Jul 2016 01:58:57 +0000 Original-Received: from localhost ([127.0.0.1]:45780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMQUo-0006uv-7M for submit@debbugs.gnu.org; Sun, 10 Jul 2016 21:58:57 -0400 Original-Received: from mail-it0-f43.google.com ([209.85.214.43]:36758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMQUe-0006uJ-PU; Sun, 10 Jul 2016 21:58:48 -0400 Original-Received: by mail-it0-f43.google.com with SMTP id f6so43260852ith.1; Sun, 10 Jul 2016 18:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7QAmPWt7LqGe52j5ZeHzTxIlxmLlgHOF97E5t5v82iw=; b=EUlgNjOIrCUYURYvcT9cemNch+i2QzWuFdtbP6gwjnAoO2n10y3K9R529coA/Oa6C+ Bxaw9irkvqFCbEG8Ul5/k10Mw2/si6cFjX7zM6cCse8RBaBJVezSf9bdHOtyQugeB21L v+druOQsy2ifClfSteyhoyYwaejh7fIW5J4MUZaTdXpi8HEGS7UBwdFZcDif1nVmLcqz MLbAX78E46FpcrjvV8+NO5JLxNK23/zP/zJ5gnM/o1J5wya3QiGQoBfGMOWtPRg5PH9w jilHcYXWb1PapKTY7KmA55NqpVp5vpCyti0jHoh6BKvO3Edzlz5UYiYK/4/RD2BFdw9q Sqrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=7QAmPWt7LqGe52j5ZeHzTxIlxmLlgHOF97E5t5v82iw=; b=K2y26wQk+V4PKyCm7M7Opn+3+TmFQa+Y3VDp9sITTGgSsTARog09wgrEaL6DFJETa1 g3gGySlr6pqImCeIMoMPQfxf8ZXAMmerqdjZrtfO+pCZ91l4O9cO1oPzEj+g3vcr3wt8 Y1W3iXObAQyfNRM633NOAA1hXEVx2cu40gEDVqCnSs/hcoZXjGr5//4qDzTi39QjmXjQ ltYjQfjtlR+Wm2iiB7kx3k28VlSBn89i3NGgvjwIwDszdnj4hYWSCmeDsbSMfjxLdqdt jJPymyBrYGkqWHcsuEbm57zgkPnOs5+WXQ3yBscHHxLFT1wJ6jpUXRx7T4H1qYpcP1Ps AaHw== X-Gm-Message-State: ALyK8tI8+/cifPZSygJt8in9zBO2B9AvWLFv5ufjO0QvVVVl8UT2lHq5H4iBL2ih1HZMww== X-Received: by 10.36.82.82 with SMTP id d79mr8322594itb.3.1468202319283; Sun, 10 Jul 2016 18:58:39 -0700 (PDT) Original-Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id l184sm6588242itd.14.2016.07.10.18.58.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Jul 2016 18:58:38 -0700 (PDT) In-Reply-To: (Lars Magne Ingebrigtsen's message of "Wed, 13 Jul 2011 16:08:17 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120824 Archived-At: --=-=-= Content-Type: text/plain tags 4655 patch quit Lars Magne Ingebrigtsen writes: > Stefan Monnier writes: > >>>> 2- save-excursion saves the "position and current buffer" as a marker. >>>> Combine 1 and 2 together, and you'll see that save-excursion ends up >>>> changing the current buffer. >> >>> Oops. Yes, I see. >>> Well, we could document it, but from my POV it looks more like a bug >>> than a "feature". >> >> Agreed. This said, we have a problem. > > Has this been fixed? I seem to be unable to reproduce this bug in Emacs > 24... Reproduces for me with 23.4 up through 25.0.95. So here's a patch to mention it in the manual: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Document-buffer-swap-text-save-excursion-interact.patch Content-Description: patch >From 7c79e2f1aef7e59d80d7b46533a93f2f23ad6759 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sun, 10 Jul 2016 21:52:23 -0400 Subject: [PATCH v1] Document buffer-swap-text+save-excursion interaction * doc/lispref/buffers.texi (Swapping Text): Add warning about interaction of `buffer-swap-text' and `save-excursion' (Bug #4655). --- doc/lispref/buffers.texi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/lispref/buffers.texi b/doc/lispref/buffers.texi index 1f7f263..22c6726 100644 --- a/doc/lispref/buffers.texi +++ b/doc/lispref/buffers.texi @@ -1211,6 +1211,11 @@ Swapping Text overlays, the text properties, the undo list, the value of the @code{enable-multibyte-characters} flag (@pxref{Text Representations, enable-multibyte-characters}), etc. + +@strong{Warning:} The current buffer will be set to @var{buffer} if +this function is called from within @code{save-excursion}, since the +marker used by @code{save-excursion} to save the position and buffer +will be swapped as well. @end defun If you use @code{buffer-swap-text} on a file-visiting buffer, you -- 2.8.0 --=-=-=--