From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: auto-generating skeleton ChangeLogs Date: Tue, 12 Jul 2016 09:49:21 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <874m7v7yqm.fsf@lifelogs.com> References: <4hd1rw1ubr.fsf@fencepost.gnu.org> <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <87twg2g86g.fsf@lifelogs.com> <83eg76n5h5.fsf@gnu.org> <87y45eeoor.fsf@lifelogs.com> <577D42BB.1020500@cs.ucla.edu> <87oa694rfw.fsf@russet.org.uk> <837fcxlbay.fsf@gnu.org> <87lh1d2wg5.fsf@russet.org.uk> <83eg75jk5h.fsf@gnu.org> <87lh1cb6p0.fsf@lifelogs.com> <87d1mma0av.fsf@lifelogs.com> <87vb0c8fsb.fsf_-_@lifelogs.com> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468331480 24970 80.91.229.3 (12 Jul 2016 13:51:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Jul 2016 13:51:20 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 12 15:51:08 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bMy5T-000413-Gs for ged-emacs-devel@m.gmane.org; Tue, 12 Jul 2016 15:50:59 +0200 Original-Received: from localhost ([::1]:40634 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMy5N-0003av-82 for ged-emacs-devel@m.gmane.org; Tue, 12 Jul 2016 09:50:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60301) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMy4j-0003aZ-4m for emacs-devel@gnu.org; Tue, 12 Jul 2016 09:50:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMy4e-0000m3-5o for emacs-devel@gnu.org; Tue, 12 Jul 2016 09:50:12 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:54761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMy4d-0000lo-WD for emacs-devel@gnu.org; Tue, 12 Jul 2016 09:50:08 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1bMy4b-0003c9-3C for emacs-devel@gnu.org; Tue, 12 Jul 2016 15:50:05 +0200 Original-Received: from c-98-229-60-157.hsd1.ma.comcast.net ([98.229.60.157]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 12 Jul 2016 15:50:05 +0200 Original-Received: from tzz by c-98-229-60-157.hsd1.ma.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 12 Jul 2016 15:50:05 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 27 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-98-229-60-157.hsd1.ma.comcast.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:vd9vTSTzZ4/8jr1pRaEWUp1VO+g= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205577 Archived-At: On Mon, 11 Jul 2016 09:28:52 -0400 Ted Zlatanov wrote: TZ> Can we do better? What are the things we can catch, given a patch or VCS TZ> commit and the VCS-controlled file? TZ> * additions of variables: defvar, defcustom, ??? TZ> * additions of functions: defun, defun*, ??? TZ> * removals of variables and functions TZ> * changes to defcustoms or defvars TZ> * changes to functions TZ> * other top-level macros such as `define-minor-mode' TZ> * new files, deleted files TZ> If there is code already written for this in Emacs or other packages, TZ> great. If not, I guess it should be part of the VC mode? ...another approach I thought of: step through every - or + line of the patch and do `add-change-log-entry'. The functionality to detect the current function or symbol changed will have to be factored out, so we can use a "change" data structure instead of inserting the ChangeLog entry. Then walk through the list of changes and consolidate them into a tree structure. That would be the minimum effort implementation... Would that cover enough of the cases above? Ted