From: Michael Albinus <michael.albinus@gmx.de>
To: npostavs@users.sourceforge.net
Cc: 16984@debbugs.gnu.org, jidanni@jidanni.org
Subject: bug#16984: dired-do-rename susceptible to .../~/... hijack
Date: Sat, 29 Oct 2016 18:22:01 +0200 [thread overview]
Message-ID: <874m3vazx2.fsf@gmx.de> (raw)
In-Reply-To: <87h97vqhf3.fsf@users.sourceforge.net> (npostavs's message of "Sat, 29 Oct 2016 11:54:56 -0400")
npostavs@users.sourceforge.net writes:
>> Prefixing with "/:" would also deactivate all file name handlers. The
>> file name "/ssh:user@host:/path/~/file" would be handled literally,
>> which is wrong.
>
> Ah, good point. How about checking (find-file-name-handler filename
> 'substitute-in-file-name):
>
> + (not (let ((handler (find-file-name-handler
> + filename 'substitute-in-file-name)))
> + (and handler
> + (funcall handler 'substitute-in-file-name filename)))))
I would rather use (not (file-remote-p file-name))
This fixes the problem for local file names, but not for remote
ones. "/ssh:user@host:/path/~/file" would still be expanded to something
like "/ssh:user@host:/home/user/file". Well, better than nothing.
What do people think to use the "/:" prefix also for the local part of
remote file names? Then one could use "/ssh:user@host:/:/path/~/file",
making substitute-in-file-name a noop.
Best regards, Michael.
next prev parent reply other threads:[~2016-10-29 16:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 18:10 bug#16984: dired-do-rename susceptible to .../~/... hijack 積丹尼 Dan Jacobson
2016-10-23 2:21 ` npostavs
2016-10-23 6:50 ` Eli Zaretskii
2016-10-29 2:27 ` npostavs
2016-10-29 7:01 ` Eli Zaretskii
2016-10-29 13:23 ` Michael Albinus
2016-10-29 15:54 ` npostavs
2016-10-29 16:22 ` Michael Albinus [this message]
2016-11-01 0:42 ` npostavs
2016-12-04 19:06 ` Michael Albinus
2016-12-08 1:47 ` npostavs
2016-12-08 8:23 ` Michael Albinus
2016-12-08 14:39 ` npostavs
2016-12-08 14:58 ` Michael Albinus
2016-12-08 17:03 ` Michael Albinus
2016-12-08 16:00 ` Eli Zaretskii
2016-12-09 4:56 ` npostavs
2016-12-09 8:05 ` Michael Albinus
2016-12-12 2:57 ` npostavs
2016-12-09 8:19 ` Eli Zaretskii
2016-12-08 15:58 ` Eli Zaretskii
2016-12-08 16:25 ` Michael Albinus
2016-12-08 17:23 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m3vazx2.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=16984@debbugs.gnu.org \
--cc=jidanni@jidanni.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.