From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#25132: 26.0.50; emacs hangs when loading org file with python source blocks Date: Mon, 23 Jan 2017 22:36:13 -0500 Message-ID: <874m0puo2a.fsf@users.sourceforge.net> References: <4aa23451-b6cd-88b0-369e-99f6fe5f2175@gmail.com> <87y3yn2x4j.fsf@users.sourceforge.net> <87eg0e36un.fsf@users.sourceforge.net> <878tq6wo1p.fsf@users.sourceforge.net> <345079d3-9578-9ab9-1444-353843a70f8b@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1485229002 19481 195.159.176.226 (24 Jan 2017 03:36:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 24 Jan 2017 03:36:42 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: David Dynerman , 25132@debbugs.gnu.org, =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 24 04:36:37 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cVru6-0003BB-1G for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Jan 2017 04:36:18 +0100 Original-Received: from localhost ([::1]:45863 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVru9-0007Ah-51 for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Jan 2017 22:36:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVrtv-000797-2j for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2017 22:36:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVrtu-0000Us-9Y for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2017 22:36:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41414) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cVrtp-0000U2-VE; Mon, 23 Jan 2017 22:36:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cVrtp-00082E-Q8; Mon, 23 Jan 2017 22:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Tue, 24 Jan 2017 03:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25132 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 25132-submit@debbugs.gnu.org id=B25132.148522891430828 (code B ref 25132); Tue, 24 Jan 2017 03:36:01 +0000 Original-Received: (at 25132) by debbugs.gnu.org; 24 Jan 2017 03:35:14 +0000 Original-Received: from localhost ([127.0.0.1]:39613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cVrt4-00081A-BZ for submit@debbugs.gnu.org; Mon, 23 Jan 2017 22:35:14 -0500 Original-Received: from mail-it0-f44.google.com ([209.85.214.44]:36170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cVrt2-00080w-3t for 25132@debbugs.gnu.org; Mon, 23 Jan 2017 22:35:12 -0500 Original-Received: by mail-it0-f44.google.com with SMTP id c7so77832091itd.1 for <25132@debbugs.gnu.org>; Mon, 23 Jan 2017 19:35:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=cNGhgOY4IFRNdoxPxkam4Oyg4OCozL0VVcRfKo9dolw=; b=gf5/gUfqCgIrii4BtyMof8JRE2k0oT+ejHC3orFS0K0L6JlgrkgmQAw2dlD8LEdWgV ZCKWKen+we2iJB1CUyVT3YslbJnaLE0GP4tQipNJN1LlMvFzO+e5YmgsWS0K98ZbKxo9 YuLSNSEHihFCpetVtEw3VD/6kDAMGusM5OZfpS6gZlnz0bkVXO15GvIa8yugO32fpFZc HlZAUohVpLRz8hqbcC4xaW+bf3a69iqvEnXMiM0H0q5F/KW2Qbm0u8dOqkxhppIGIIk0 N9pDeoD8nuWc1YMjpnRZaABO9inCe3HZnJXpuPKjgyqVGgjAIKdYouU9NGdOOxYBTncx EhMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=cNGhgOY4IFRNdoxPxkam4Oyg4OCozL0VVcRfKo9dolw=; b=JyvzADE6qHtIdncE2nSwxmIMeI9WRoQwwE+tSKjcPc7cYLZ8wLkI5ErwgPr5lRDAJt msPwdvoSrI96sHuPALFZ/oDM1e8/YLxUIClmO19ru4uDT1QFpgYCaqhU8zch2Hf/Qbkc ltbLnnbCcZqsi7eZ1buMPNUnVOWCeOW0cLoTWWkuhZVKYQD1dQ0zGe9oVkwTCU2eLw9e 3fw+6mUpTnP2CKPZ11/iREzdzQcHikb0+45p+/bvIi0DfyqN3zHB08+/+cz32wbrNiAt 0gsXuhB7FOKkhYMZpZDtr8tISXRxX4Shhrddov+rzRt7Y28KV65hlAEMPZK4nY/688NR dePQ== X-Gm-Message-State: AIkVDXLvQohIQFVuWQjglRrhab6OABy05eVj9F8RzjoHlDywCjXzmdWV8Z/BXHlpJBMPOQ== X-Received: by 10.36.91.137 with SMTP id g131mr7341695itb.55.1485228906580; Mon, 23 Jan 2017 19:35:06 -0800 (PST) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 62sm9485279itl.1.2017.01.23.19.35.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jan 2017 19:35:05 -0800 (PST) In-Reply-To: <345079d3-9578-9ab9-1444-353843a70f8b@yandex.ru> (Dmitry Gutov's message of "Mon, 23 Jan 2017 06:53:21 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128350 Archived-At: Dmitry Gutov writes: > On 20.01.2017 03:52, npostavs@users.sourceforge.net wrote: > >> My feeling is that inhibit-modification-hooks should usually be buffer >> local anyway. > > Maybe you're right. > > inhibit-read-only, bound nearby, seems to be in the same situation. > >>> If we are not, why not make inhibit-modification-hooks always >>> buffer-local instead? >> >> It would have to be in addition to, because even after doing >> (make-variable-buffer-local 'var), (let ((var 'foo))...) still makes a >> global binding. `make-variable-buffer-local' only has effect for >> `setq', which I think will hardly ever happen for >> `inhibit-modification-hooks'. > > You're right, and that sounds a little too complicated for my taste. > > So, personally, I'd try to fix the particular instance > first. Switching buffers inside with-silent-modifications is not a > very common usage, I think. > > Maybe org-src should itself let-bind the aforementioned variable(s) > where it visits other buffers. Yeah, that works, and is my proposal for emacs-25, but I'm still leaning towards solving this more broadly in with-silent-modifications, probably also add a mention about this to the inhibit-modification-hooks docstring. I think doing the same to inhibit-read-only isn't worth the trouble because if it happens to be let-bound to t in a buffer where it wasn't "supposed" to be, the worst that happens is that an error *isn't* thrown.