* bug#25124: [PATCH] gnus-message-citation-mode should fontify if derived from message-mode.
@ 2016-12-06 9:27 Hong Xu
2017-02-16 22:12 ` Hong Xu
2019-06-24 23:22 ` bug#25022: " Lars Ingebrigtsen
0 siblings, 2 replies; 3+ messages in thread
From: Hong Xu @ 2016-12-06 9:27 UTC (permalink / raw)
To: 25124
* gnus-cite.el (gnus-message-citation-mode): Fontify if the major
mode is derived from message-mode (not necessarily equal to
message-mode).
---
lisp/gnus/gnus-cite.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/gnus/gnus-cite.el b/lisp/gnus/gnus-cite.el
index 502a3be35550..e012b256d09d 100644
--- a/lisp/gnus/gnus-cite.el
+++ b/lisp/gnus/gnus-cite.el
@@ -1204,7 +1204,7 @@ gnus-message-citation-mode
nil ;; init-value
"" ;; lighter
nil ;; keymap
- (when (eq major-mode 'message-mode) ;FIXME: Use derived-mode-p.
+ (when (derived-mode-p 'message-mode)
;; FIXME: Use font-lock-add-keywords!
(let ((defaults (car (if (featurep 'xemacs)
(get 'message-mode 'font-lock-defaults)
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* bug#25124: [PATCH] gnus-message-citation-mode should fontify if derived from message-mode.
2016-12-06 9:27 bug#25124: [PATCH] gnus-message-citation-mode should fontify if derived from message-mode Hong Xu
@ 2017-02-16 22:12 ` Hong Xu
2019-06-24 23:22 ` bug#25022: " Lars Ingebrigtsen
1 sibling, 0 replies; 3+ messages in thread
From: Hong Xu @ 2017-02-16 22:12 UTC (permalink / raw)
To: 25124
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
On 2016-12-06 Tue 01:27 GMT-0800, Hong Xu <hong@topbug.net> wrote:
> * gnus-cite.el (gnus-message-citation-mode): Fontify if the major
> mode is derived from message-mode (not necessarily equal to
> message-mode).
> ---
> lisp/gnus/gnus-cite.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/gnus/gnus-cite.el b/lisp/gnus/gnus-cite.el
> index 502a3be35550..e012b256d09d 100644
> --- a/lisp/gnus/gnus-cite.el
> +++ b/lisp/gnus/gnus-cite.el
> @@ -1204,7 +1204,7 @@ gnus-message-citation-mode
> nil ;; init-value
> "" ;; lighter
> nil ;; keymap
> - (when (eq major-mode 'message-mode) ;FIXME: Use derived-mode-p.
> + (when (derived-mode-p 'message-mode)
> ;; FIXME: Use font-lock-add-keywords!
> (let ((defaults (car (if (featurep 'xemacs)
> (get 'message-mode 'font-lock-defaults)
Still consider this patch? The fix is quite straightforward.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#25022: bug#25124: [PATCH] gnus-message-citation-mode should fontify if derived from message-mode.
2016-12-06 9:27 bug#25124: [PATCH] gnus-message-citation-mode should fontify if derived from message-mode Hong Xu
2017-02-16 22:12 ` Hong Xu
@ 2019-06-24 23:22 ` Lars Ingebrigtsen
1 sibling, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2019-06-24 23:22 UTC (permalink / raw)
To: Hong Xu; +Cc: 25124, 25022
Hong Xu <hong@topbug.net> writes:
> * gnus-cite.el (gnus-message-citation-mode): Fontify if the major
> mode is derived from message-mode (not necessarily equal to
> message-mode).
Thanks; applied to the Emacs trunk.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-24 23:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-06 9:27 bug#25124: [PATCH] gnus-message-citation-mode should fontify if derived from message-mode Hong Xu
2017-02-16 22:12 ` Hong Xu
2019-06-24 23:22 ` bug#25022: " Lars Ingebrigtsen
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.