all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Hong Xu <hong@topbug.net>
To: 25124@debbugs.gnu.org
Subject: bug#25124: [PATCH] gnus-message-citation-mode should fontify if derived from message-mode.
Date: Thu, 16 Feb 2017 14:12:42 -0800	[thread overview]
Message-ID: <874lztg4yt.fsf@topbug.net> (raw)
In-Reply-To: <1481016446-26329-1-git-send-email-hong@topbug.net>

[-- Attachment #1: Type: text/plain, Size: 911 bytes --]


On 2016-12-06 Tue 01:27 GMT-0800, Hong Xu <hong@topbug.net> wrote:

> 	* gnus-cite.el (gnus-message-citation-mode): Fontify if the major
> 	mode is derived from message-mode (not necessarily equal to
> 	message-mode).
> ---
>  lisp/gnus/gnus-cite.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/gnus/gnus-cite.el b/lisp/gnus/gnus-cite.el
> index 502a3be35550..e012b256d09d 100644
> --- a/lisp/gnus/gnus-cite.el
> +++ b/lisp/gnus/gnus-cite.el
> @@ -1204,7 +1204,7 @@ gnus-message-citation-mode
>    nil ;; init-value
>    "" ;; lighter
>    nil ;; keymap
> -  (when (eq major-mode 'message-mode)   ;FIXME: Use derived-mode-p.
> +  (when (derived-mode-p 'message-mode)
>      ;; FIXME: Use font-lock-add-keywords!
>      (let ((defaults (car (if (featurep 'xemacs)
>  			     (get 'message-mode 'font-lock-defaults)


Still consider this patch? The fix is quite straightforward.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2017-02-16 22:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-06  9:27 bug#25124: [PATCH] gnus-message-citation-mode should fontify if derived from message-mode Hong Xu
2017-02-16 22:12 ` Hong Xu [this message]
2019-06-24 23:22 ` bug#25022: " Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lztg4yt.fsf@topbug.net \
    --to=hong@topbug.net \
    --cc=25124@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.