bug#26258: 26.0.50; recentf and tramp

bug#26258: 26.0.50; recentf and tramp

[Stephen Berman]

[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]

Let the file ~/.emacs.d/recentf contain a tramp-sensitive entry,
e.g. let it consist of the following:

--8<---------------cut here---------------start------------->8---
;;; Automatically generated by ‘recentf’ on Sat Mar 25 11:51:22 2017.

(setq recentf-list
      '(
        "/su:root@rosalinde:/etc/"
        ))

(setq recentf-filter-changer-current 'nil)

\f
;; Local Variables:
;; coding: utf-8-emacs
;; End:
--8<---------------cut here---------------end--------------->8---

and let ~/.emacs consist of this line:
(recentf-mode 1)
Alternatively, customize the variable recentf-mode to t and save this
setting.

Now starting emacs raises the error "Variable binding depth exceeds
max-specpdl-size" and recentf-mode is not enabled.  Starting emacs with
--debug-init produces the attached backtrace.

(With the above recentf file, starting emacs with `-Q --eval
"(recentf-mode 1)"' or with `-Q --eval "(custom-set-variables
'(recentf-mode t))"' does not raise an error but prompts for the
password for the file "/su:root@rosalinde:/etc/".)


In GNU Emacs 26.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.20.10)
 of 2017-03-24 built on rosalinde
Repository revision: 4fbd330fae54a9c45d4a717127aa86d75e9938d5
Windowing system distributor 'The X.Org Foundation', version 11.0.11803000
System Description:	openSUSE Leap 42.2


[-- Attachment #2: backtrace --]
[-- Type: application/octet-stream, Size: 89293 bytes --]

bug#26258: 26.0.50; recentf and tramp

[Michael Albinus]

Stephen Berman <stephen.berman@gmx.net> writes:

Hi Stephen,

> Now starting emacs raises the error "Variable binding depth exceeds
> max-specpdl-size" and recentf-mode is not enabled.  Starting emacs with
> --debug-init produces the attached backtrace.

I've pushed a fix to master which shall fix the recursive load for
Tramp, could you pls check?

I'm not a recentf user, so I don't know whether it behaves correctly in
your scenario, loading remote recentf files.

Best regards, Michael.

bug#26258: 26.0.50; recentf and tramp

[Stephen Berman]

On Sun, 26 Mar 2017 17:40:57 +0200 Michael Albinus <michael.albinus@gmx.de> wrote:

> Stephen Berman <stephen.berman@gmx.net> writes:
>
> Hi Stephen,
>
>> Now starting emacs raises the error "Variable binding depth exceeds
>> max-specpdl-size" and recentf-mode is not enabled.  Starting emacs with
>> --debug-init produces the attached backtrace.
>
> I've pushed a fix to master which shall fix the recursive load for
> Tramp, could you pls check?

Thanks, I rebuilt Emacs with your fix and confirm there's now no error
and recentf-mode does get enabled; but...

> I'm not a recentf user, so I don't know whether it behaves correctly in
> your scenario, loading remote recentf files.

... now the remote file "/su:root@rosalinde:/etc/" is removed from
recentf-save-file on enabling recentf-mode.  This does not happen in
Emacs 25.2.  The difference appears to be due to what happens when
file-remote-p is called (from recentf-keep-default-predicate): in 25.2
(file-remote-p "/su:root@rosalinde:/etc/") returns "/su:root@rosalinde:"
but in master with your fix, it raises a void-function error:

Debugger entered--Lisp error: (void-function tramp-file-name-handler)
  tramp-file-name-handler(file-remote-p "/su:root@rosalinde:/etc/" nil nil)
  file-remote-p("/su:root@rosalinde:/etc/")
  eval((file-remote-p "/su:root@rosalinde:/etc/") nil)
  elisp--eval-last-sexp(t)
  eval-last-sexp(t)
  eval-print-last-sexp(nil)
  funcall-interactively(eval-print-last-sexp nil)
  call-interactively(eval-print-last-sexp nil nil)
  command-execute(eval-print-last-sexp)

> Best regards, Michael.

Steve Berman

bug#26258: 26.0.50; recentf and tramp

[Michael Albinus]

Stephen Berman <stephen.berman@gmx.net> writes:

Hi Stephen,

> Debugger entered--Lisp error: (void-function tramp-file-name-handler)
>   tramp-file-name-handler(file-remote-p "/su:root@rosalinde:/etc/" nil nil)
>   file-remote-p("/su:root@rosalinde:/etc/")
>   eval((file-remote-p "/su:root@rosalinde:/etc/") nil)
>   elisp--eval-last-sexp(t)
>   eval-last-sexp(t)
>   eval-print-last-sexp(nil)
>   funcall-interactively(eval-print-last-sexp nil)
>   call-interactively(eval-print-last-sexp nil nil)
>   command-execute(eval-print-last-sexp)

Oops, I forgot to autoload `tramp-file-name-handler'. Could pls check again?

> Steve Berman

Best regards, Michael.

bug#26258: 26.0.50; recentf and tramp

[Stephen Berman]

On Mon, 27 Mar 2017 10:16:04 +0200 Michael Albinus <michael.albinus@gmx.de> wrote:

> Stephen Berman <stephen.berman@gmx.net> writes:
>
> Hi Stephen,
>
>> Debugger entered--Lisp error: (void-function tramp-file-name-handler)
>>   tramp-file-name-handler(file-remote-p "/su:root@rosalinde:/etc/" nil nil)
>>   file-remote-p("/su:root@rosalinde:/etc/")
>>   eval((file-remote-p "/su:root@rosalinde:/etc/") nil)
>>   elisp--eval-last-sexp(t)
>>   eval-last-sexp(t)
>>   eval-print-last-sexp(nil)
>>   funcall-interactively(eval-print-last-sexp nil)
>>   call-interactively(eval-print-last-sexp nil nil)
>>   command-execute(eval-print-last-sexp)
>
> Oops, I forgot to autoload `tramp-file-name-handler'. Could pls check again?

Just did, and now it works as it should: remote files remain in
recent-save-file and recentf-mode is enabled without error.  Thanks!

Steve Berman

bug#26258: 26.0.50; recentf and tramp

[Michael Albinus]

Stephen Berman <stephen.berman@gmx.net> writes:

Hi Stephen,

> Just did, and now it works as it should: remote files remain in
> recent-save-file and recentf-mode is enabled without error.  Thanks!

Thanks for the feedback. I'm closing the bug.

> Steve Berman

Best regards, Michael.